After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786446 - Document filesystem resize and repair
Document filesystem resize and repair
Status: RESOLVED FIXED
Product: gnome-user-docs
Classification: Core
Component: gnome-help
3.25.x
Other Linux
: Normal normal
: ---
Assigned To: Maintainers of Gnome user documentation
Maintainers of Gnome user documentation
Depends on:
Blocks:
 
 
Reported: 2017-08-17 21:30 UTC by Kai Lüke
Modified: 2017-09-13 04:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Document filesystem resize and repair (8.02 KB, patch)
2017-08-17 21:35 UTC, Kai Lüke
none Details | Review
Document filesystem resize and repair (8.76 KB, patch)
2017-08-28 05:25 UTC, Kai Lüke
none Details | Review
Document filesystem resize and repair (8.83 KB, patch)
2017-09-11 15:30 UTC, Kai Lüke
committed Details | Review

Description Kai Lüke 2017-08-17 21:30:55 UTC
For the 3.26 release there will be support to check and repair filesystems as well as to resize filesystems and partitions. The actions can be destructive and need to hint about having a backup and advanced recovery if the repair resulted in partly recovered files.
Comment 1 Kai Lüke 2017-08-17 21:35:25 UTC
Created attachment 357842 [details] [review]
Document filesystem resize and repair

Are pkgrevision="3.25.90" and status="review" correct?
Are there too many or too less sentences together in a <p>?

Regards,
Kai
Comment 2 Petr Kovar 2017-08-27 12:22:42 UTC
Comment on attachment 357842 [details] [review]
Document filesystem resize and repair

>+  <p>If the filesystem structure is damaged it can affect the files stored in it. In some cases these files can not be brought into a valid form again and will be deleted or moved to a special directory. It is normally the <em>lost+found</em> folder in the top level directoy of the filesystem where these recovered file parts can be found. 


Start a new paragraph here.


> If the data is to valuable to be lost during this process you are advised to back it up by saving an image of the volume before repairing.


"If the data is too valuable to be lost during this process, you are advised to back it up by saving an image of the volume before repairing."

Start a new paragraph here.


>+    <p>After completion you will be notified whether the filesystem could be successfully repaired. In case of success it can be used as again in the normal way.</p>


"In case of success it can be used again in the normal way."


>+    <p>If the filesystem could not be repaired you should back it up by saving an image of the volume in order to retrieve important files later. 


"If the filesystem could not be repaired, back it up by saving an image of the volume to be able to retrieve important files later."


> This can be done by mounting the image read-only or using forensic analysis tools like <app>sleuthkit</app>. 


Start a new paragraph here.


>diff --git a/gnome-help/C/disk-resize.page b/gnome-help/C/disk-resize.page
>new file mode 100644
>index 00000000..963e39b1
>--- /dev/null
>+++ b/gnome-help/C/disk-resize.page
>@@ -0,0 +1,53 @@
>+<page xmlns="http://projectmallard.org/1.0/"
>+      type="topic" style="task"
>+      id="disk-resize">
>+  <info>
>+    <link type="guide" xref="disk"/>
>+
>+
>+    <credit type="author">
>+      <name>GNOME Documentation Project</name>
>+      <email>gnome-doc-list@gnome.org</email>
>+    </credit>
>+
>+    <revision pkgversion="3.25.90" date="2017-08-17" status="review"/>
>+
>+    <desc>Shrink or grow a filesystem and its partition.</desc>
>+    <include href="legal.xml" xmlns="http://www.w3.org/2001/XInclude"/>
>+  </info>
>+
>+<title>Adjust the size of a filesystem</title>
>+
>+  <p>A filesystem can be grown to make use of the free space after its partition. Often this is even possible while the filesystem is mounted.</p>
>+  <p>To make space for another partition after the filesystem it can be shrunk according to the free space within it.</p>


"To make space for another partition after the filesystem, it can be shrunk according to the free space within it."


>+    <p>Depending on how much data has to be moved from the shrunk part the filesystem resize may take longer time.</p>
>+    <note style="warning">


"Depending on how much data has to be moved from the shrunk part, the filesystem resize may take longer time."


>+      <p>It automatically involves <link xref="disk-repair">repairing</link> of the filesystem. 


"The filesystem resize automatically involves <link xref="disk-repair">repairing</link> of the filesystem."


>+      <p>Confirm to start the action by clicking <gui style="button">Resize</gui>.</p>


This could be a separate step, actually.
Comment 3 Petr Kovar 2017-08-27 12:49:10 UTC
Review of attachment 357842 [details] [review]:

Many thanks for your patch! Overall, it looks good. 

> Are pkgrevision="3.25.90" and status="review" correct?

Yep, that's fine.

> Are there too many or too less sentences together in a <p>?

Too many in some cases, see my comments above.

Also, please wrap all lines at 80 characters or less.
Comment 4 Petr Kovar 2017-08-27 13:37:26 UTC
As an additional note: we also need to update gnome-help/Makefile.am accordingly, since we are adding new files.
Comment 5 Kai Lüke 2017-08-28 05:25:36 UTC
Created attachment 358560 [details] [review]
Document filesystem resize and repair

Hello,

thanks for the feedback. I've updated accordingly.

Regards,
Kai
Comment 6 Kai Lüke 2017-09-11 13:35:08 UTC
This won't be in today's release because of no translation time anyway, right?
But do you think it can be reviewed before the .1 release?

Best greetings,
Kai
Comment 7 André Klapper 2017-09-11 15:02:42 UTC
Kai: Thanks for the rework! 
Assuming that all of Petr's comments have been incorporated (didn't check thoroughly I admit), it seems that line wraps are still missing in disk-repair.page? :)
Comment 8 Kai Lüke 2017-09-11 15:30:03 UTC
Created attachment 359538 [details] [review]
Document filesystem resize and repair

Thanks, the upper part is now wrapped as well.
Comment 9 Petr Kovar 2017-09-13 04:35:23 UTC
Review of attachment 359538 [details] [review]:

Committed as 70e287118048538537d77c26c6ae472dab8f2b1b as part of the stable release. Thank you!