GNOME Bugzilla – Bug 786397
Increase libarchive version requirement
Last modified: 2017-09-21 21:47:37 UTC
As mentioned recently in IRC, evince does not compile with older libarchive versions due to use of the archive_free and archive_entry_is_encrypted functions.
Created attachment 357767 [details] [review] Increase-libarchive-version-requirement.patch This patch increases the required libarchive version to 3.1.900a, which is when these functions were introduced.
What kind of version number is that? I'm surprised pkg-config handles version numbers with non numeric values :-) Is that an "stable" version? Maybe it's better to bump to 3.2.0?
I think it's like an alpha. The libarchive commit messages say it's a test release. The version is listed that way in the libarchive git tags, the download page (https://www.libarchive.org/downloads/), and in the .pc files. I tested the version numbers with pkg-config and they seemed to be handled correctly; Asking pkg-config for version >= 3.1.900a accepts versions 3.1.900a, 3.1.901a, and 3.2.0 and rejects version 3.1.2. But I think requiring version >= 3.2.0 would be fine too.
Created attachment 357981 [details] [review] Increase-libarchive-version-requirement.patch [3.2.0] This patch increases the required libarchive version to 3.2.0.
Review of attachment 357981 [details] [review]: > functions, which were introduced in libarchive 3.1.900a. Can you mention that this version is an alpha/pre-release version of 3.2.0? Otherwise it makes it quite weird to mention one version but use another. Looks good otherwise.
Created attachment 360230 [details] [review] Increase-libarchive-version-requirement.patch Updated patch. Sorry it's taken so long, I've been busy with other things lately.