After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786204 - gsf-memmove.patch seems to be no longer needed?
gsf-memmove.patch seems to be no longer needed?
Status: RESOLVED FIXED
Product: gtk-osx
Classification: Other
Component: General
unspecified
Other Mac OS
: Normal normal
: ---
Assigned To: GTK Mac Integration Maintainers
GTK Mac Integration Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-12 16:56 UTC by Lee Read
Modified: 2017-08-13 20:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Lee Read 2017-08-12 16:56:58 UTC 
It looks to me like the gsf-memmove.patch is no longer neeeded: https://github.com/jralls/gtk-osx-build/blob/master/patches/gsf-memmove.patch

--[begin build output dump]---
*** Applying patch https://git.gnome.org/browse/gtk-osx/plain/patches/gsf-memmove.patch *** [49/69]
patch -p1 < "/Users/gnucash/.cache/jhbuild/gsf-memmove.patch"
patching file gsf/gsf-output-iconv.c
Reversed (or previously applied) patch detected!  Assume -R? [n] ^C*** Error during phase checkout of libgsf: ########## Error running patch -p1 < "/Users/gnucash/.cache/jhbuild/gsf-memmove.patch" *** [49/69]

  [1] Rerun phase checkout
  [2] Ignore error and continue to configure
  [3] Give up on module
  [4] Start shell
  [5] Reload configuration
  [6] Go to phase "wipe directory and start over"
--[end build output dump]---

If I look at the patch and the target file, the intended fix seems to be already in the target.
Comment 1 John Ralls 2017-08-13 20:18:20 UTC 
Fixed, thanks.