After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786189 - [PATCH] gs-plugin-packagekit-proxy: pass the complete proxy settings
[PATCH] gs-plugin-packagekit-proxy: pass the complete proxy settings
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-08-12 08:10 UTC by Xiang Fan
Modified: 2017-08-27 02:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (6.75 KB, patch)
2017-08-12 08:10 UTC, Xiang Fan 		committed Details | Review

Description Xiang Fan 2017-08-12 08:10:45 UTC 
Created attachment 357462 [details] [review]
Patch

The packagekit library has been using the new API for a long time. This
patch ensures that all proxy settings are provided to packagekit as
required.
Comment 1 Richard Hughes 2017-08-12 13:09:15 UTC 
Do we have to raise the PK dep ver in meson.build?
Comment 2 Xiang Fan 2017-08-12 22:45:36 UTC 
I don't think so. pk_control_set_proxy2_async() has been available since 0.6.13.
Comment 3 Xiang Fan 2017-08-16 07:56:31 UTC 
(In reply to Richard Hughes from comment #1)
> Do we have to raise the PK dep ver in meson.build?

Sorry to bother, but are there any other dependency issues with this patch?
Comment 4 Richard Hughes 2017-08-17 15:31:58 UTC 
No, I think it's fine.
Comment 5 Jeremy Bicha 2017-08-27 02:42:43 UTC 
Thank you!

(Pushed as requested since patch author doesn't have git commit rights yet)