GNOME Bugzilla – Bug 786170
gl: hide symbols that shouldn't be exported
Last modified: 2017-08-14 09:11:50 UTC
Created attachment 357434 [details] [review] gl: don't export symbols that are not supposed to be public Putting this into bugzilla first. Header files for these aren't installed, so presumably these symbols aren't supposed to be public, so let's make them private explicitly. There are also three debug categories which are exported and declared in public header files: gst_gl_context_debug gst_gl_sync_meta_debug gst_gl_window_debug - are those supposed to be public, or should they be moved into a private header instead?
(In reply to Tim-Philipp Müller from comment #0) > Created attachment 357434 [details] [review] [review] > gl: don't export symbols that are not supposed to be public > > gst_gl_context_debug > gst_gl_sync_meta_debug > gst_gl_window_debug > > - are those supposed to be public, or should they be moved into a private > header instead? I don't think these should be public symbols. Some window and context subclasses use the parent debug category but that could be changed easily enough.
Created attachment 357539 [details] [review] gl: make some debug categories private Like this?
commit a971aa4ba4f4a52514bba4d16839f29286e22876 (HEAD -> master, writable/master) Author: Tim-Philipp Müller <tim@centricular.com> Date: Mon Aug 14 09:33:38 2017 +0100 gl: make some debug categories private They weren't supposed to be public. https://bugzilla.gnome.org/show_bug.cgi?id=786170 commit 0b8f1f9e5454d545cabfd40bbf8220386eb122d2 Author: Tim-Philipp Müller <tim@centricular.com> Date: Fri Aug 11 18:38:41 2017 +0100 gl: don't export symbols that are not supposed to be public Make a bunch of symbols private that are currently leaked accidentally because they have a gst_* prefix and are used internally. We mark those we can't make static with G_GNUC_INTERNAL so that they get hidden with the autotools build as well (although we could just pass -fvisibility=hidden there too).
commit 58a92767d4c2931b42338111a86a1bad260f61ce (HEAD -> master) Author: Tim-Philipp Müller <tim@centricular.com> Date: Mon Aug 14 10:11:00 2017 +0100 gl: add missing new header files https://bugzilla.gnome.org/show_bug.cgi?id=786170