After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786056 - queue/queue2:: Allow re-usability after EOS
queue/queue2:: Allow re-usability after EOS
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal normal
: 1.12.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 785951
 
 
Reported: 2017-08-09 14:18 UTC by Edward Hervey
Modified: 2017-08-11 08:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
queue2: Allow re-usability after EOS (3.89 KB, patch)
2017-08-09 14:18 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2017-08-09 14:18:38 UTC 
See patch message
Comment 1 Edward Hervey 2017-08-09 14:18:43 UTC 
Created attachment 357272 [details] [review]
queue2: Allow re-usability after EOS

After EOS, it is possible for a pad to be resetted by sending
either a STREAM_START or SEGMENT event

Mimic the same behaviour when receiving STREAM_START/SEGMENT events
in queue2 if we are EOS'd
Comment 2 Sebastian Dröge (slomo) 2017-08-09 14:56:39 UTC 
Comment on attachment 357272 [details] [review]
queue2: Allow re-usability after EOS

Looks good to me, but queue/multiqueue might need the same
Comment 3 Edward Hervey 2017-08-09 14:58:16 UTC 
commit 6566eff20d250c6253af8dfc9b603c8d0850e257
Author: Edward Hervey <edward@centricular.com>
Date:   Wed Aug 9 16:15:23 2017 +0200

    queue2: Allow re-usability after EOS
    
    After EOS, it is possible for a pad to be resetted by sending
    either a STREAM_START or SEGMENT event
    
    Mimic the same behaviour when receiving STREAM_START/SEGMENT events
    in queue2 if we are EOS'd
    
    https://bugzilla.gnome.org/show_bug.cgi?id=786056



Indeed, queue also needs to be adjusted accordingly. multiqueue seems ok though.
Comment 4 Sebastian Dröge (slomo) 2017-08-11 08:07:03 UTC 
Patch is also in 1.12 now, queue patch should too
Comment 5 Sebastian Dröge (slomo) 2017-08-11 08:15:51 UTC 
commit 36372a9f4c515b93011ff78d898f63b2352cc9db (HEAD -> master, origin/master, origin/HEAD)
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Fri Aug 11 11:12:09 2017 +0300

    queue: Allow re-usability after EOS
    
    After EOS, it is possible for a pad to be resetted by sending
    either a STREAM_START or SEGMENT event
    
    Mimic the same behaviour when receiving STREAM_START/SEGMENT events
    in queue if we are EOS'd
    
    https://bugzilla.gnome.org/show_bug.cgi?id=786056