After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786034 - plugins: *queue* elements: Handle STREAM_START in EOS situation
plugins: *queue* elements: Handle STREAM_START in EOS situation
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal normal
: 1.12.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-09 08:54 UTC by Edward Hervey
Modified: 2017-08-11 08:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
plugins: *queue* elements: Handle STREAM_START in EOS situation (2.95 KB, patch)
2017-08-09 08:54 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2017-08-09 08:54:15 UTC 
See patch
Comment 1 Edward Hervey 2017-08-09 08:54:19 UTC 
Created attachment 357232 [details] [review]
plugins: *queue* elements: Handle STREAM_START in EOS situation

When queue-like elements are in "EOS" situation (received GST_FLOW_EOS
from downstream or EOS was pushed), they drain buffers/events that
wouldn't be processed anyway and let through events that might
modify the EOS situation.

Previously only GST_EVENT_EOS and GST_EVENT_SEGMENT events were let
through, but we also need to allow GST_EVENT_STREAM_START to go
through since it resets the EOS state of pads since 1.6
Comment 2 Edward Hervey 2017-08-09 10:37:33 UTC 
commit e2f8dc0aeff50de64e568831966b4df831d1fa1c
Author: Edward Hervey <edward@centricular.com>
Date:   Wed Aug 9 10:51:39 2017 +0200

    plugins: *queue* elements: Handle STREAM_START in EOS situation
    
    When queue-like elements are in "EOS" situation (received GST_FLOW_EOS
    from downstream or EOS was pushed), they drain buffers/events that
    wouldn't be processed anyway and let through events that might
    modify the EOS situation.
    
    Previously only GST_EVENT_EOS and GST_EVENT_SEGMENT events were let
    through, but we also need to allow GST_EVENT_STREAM_START to go
    through since it resets the EOS state of pads since 1.6
    
    https://bugzilla.gnome.org/show_bug.cgi?id=786034