After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786006 - tests: ipcpipeline: multiple tests flaky
tests: ipcpipeline: multiple tests flaky
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal blocker
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-08 15:53 UTC by Tim-Philipp Müller
Modified: 2018-02-23 12:18 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Tim-Philipp Müller 2017-08-08 15:53:49 UTC
+++ This bug was initially created as a clone of Bug #752214 +++

~/gst/master/gst-plugins-bad/tests/check$ GST_CHECKS=test_mpegts_tags make pipelines/ipcpipeline.torture
...
Running suite(s): ipcpipeline
Testing: test_mpegts_tags
0%: Checks: 1, Failures: 1, Errors: 0
pipelines/ipcpipeline.c:2668:F:general:test_mpegts_tags:0: Assertion 'gst_pad_send_event (pad, e)' failed
Running suite(s): ipcpipeline
Comment 1 Tim-Philipp Müller 2017-08-09 11:03:28 UTC
Also:

ipcpipeline.test_mpegts_2_state_changes: 'd->n_null' (5) is not equal to '6' (6)


ipcpipeline.test_wavparse_serialized_query: '(__extension__ ({ typedef char _GStaticAssertCompileTimeAssertion_1[(sizeof *((gint *) &(((GObject*)(source))->ref_count)) == sizeof (gint)) ? 1 : -1] __attribute__((__unused__)); (void) (0 ? *((gint *) &(((GObject*)(source))->ref_count)) ^ *((gint *) &(((GObject*)(source))->ref_count)) : 0); (gint) __atomic_load_4 (((gint *) &(((GObject*)(source))->ref_count)), 5); }))' (2) is not equal to '1' (1)

ipcpipeline.test_mpegts_serialized_query: '(__extension__ ({ typedef char _GStaticAssertCompileTimeAssertion_1[(sizeof *((gint *) &(((GObject*)(source))->ref_count)) == sizeof (gint)) ? 1 : -1] __attribute__((__unused__)); (void) (0 ? *((gint *) &(((GObject*)(source))->ref_count)) ^ *((gint *) &(((GObject*)(source))->ref_count)) : 0); (gint) __atomic_load_4 (((gint *) &(((GObject*)(source))->ref_count)), 5); }))' (2) is not equal to '1' (1)
Comment 2 George Kiagiadakis 2017-08-09 12:49:32 UTC
Hmm, I thought I had fixed all those. Looks like I just made them more rare. :(
I'll get on it asap.
Comment 3 Tim-Philipp Müller 2017-08-25 18:36:26 UTC
Disabled these tests for now

commit 9da2de196860808b2d036d38bcb6c4b8bb601d34
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Fri Aug 25 19:33:41 2017 +0100

    tests: ipcpipeline: skip broken tests
Comment 4 George Kiagiadakis 2017-08-30 15:56:55 UTC
Hopefully fixed... Please reopen if you see those failures again.


commit cf1bb83d8dd823c577252f01481e54fd4cf5e756
Author: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date:   Wed Aug 30 18:11:27 2017 +0300

    tests: ipcpipeline: make the state_changes test more deterministic
    
    Watching the STATE_CHANGED messages is way more deterministic than
    polling the state.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=786006

commit acc27197203c6e91ce2d65e4659fb40a1915f263
Author: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date:   Wed Aug 30 16:37:21 2017 +0300

    tests: ipcpipeline: fix broken exclusivity checks
    
    In most cases we want to stop the pipeline just once, but we have
    to do this from code that runs in the streaming threads and in case
    we have multiple streams, we need to make sure that we do this only
    once. The previous checks were broken, this should fix it.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=786006

commit f6cc14c85ab729b8204b31aef1c6c79aec8d9038
Author: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date:   Wed Aug 30 14:37:32 2017 +0300

    tests: ipcpipeline: attempt to make tags test more deterministic
    
    Instead of using a timeout and pushing the tags from an outside
    thread, use a pad probe and push them from the streaming thread.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=786006
Comment 5 Edward Hervey 2017-09-08 08:48:08 UTC
Still flaky 
https://ci.gstreamer.net/job/GStreamer-master/9229/testReport/
Comment 6 Tim-Philipp Müller 2018-02-23 12:18:02 UTC
ipcpipeline test has been disabled

commit 275592927b94c5fa2eb27e2c46fd1fdcfbee016c
Author: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date:   Thu Sep 21 11:46:22 2017 +0300

    tests/check: disable all ipcpipeline tests until I find a way to make them run reliably