Bug 785978 – gtk test failures with pango 1.40.8

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 785978 - gtk test failures with pango 1.40.8


Summary:	gtk test failures with pango 1.40.8


Status:	RESOLVED FIXED

Product:	pango
Classification:	Platform
Component:	general
Version:	1.40.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	pango-maint
QA Contact:	pango-maint

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2017-08-08 01:17 UTC by Jeremy Bicha
Modified:	2017-08-31 04:56 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Fix pango_default_break function for sentence start/end (2.16 KB, patch) 2017-08-16 07:16 UTC, Peng Wu	committed	Details \| Review

Description Jeremy Bicha 2017-08-08 01:17:38 UTC

Ubuntu 17.10 Alpha
gtk+ 3.22.18
glib 2.53.4
pango 1.40.8

Some of the build tests run during Ubuntu builds are failing now.

Full build log at
https://launchpad.net/~jbicha/+archive/ubuntu/temp20170806/+build/13215816

Build log excerpts below:


TEST: textbuffer... (pid=2679)
  /TextBuffer/UTF8 unknown char:                                       OK
  /TextBuffer/Line separator:                                          OK
  /TextBuffer/Backspace:                                               OK
  /TextBuffer/Logical motion:                                          
** (/build/gtk+3.0-0vdXVa/gtk+3.0-3.22.18/debian/build/shared/testsuite/gtk/.libs/textbuffer:2679): ERROR **: Sentence position 4, expected 3
FAIL
GTester: last random seed: R02S4fee257843d641ba8692560618fa6cbe
(pid=2695)


TEST: textiter... (pid=2710)
  /TextIter/Search Empty:                                              OK
  /TextIter/Search Full Buffer:                                        OK
  /TextIter/Search:                                                    OK
  /TextIter/Search Caseless:                                           OK
  /TextIter/Forward To Tag Toggle:                                     OK
  /TextIter/Forward To Line End:                                       OK
  /TextIter/Word Boundaries:                                           OK
  /TextIter/Visible Word Boundaries:                                   OK
  /TextIter/Cursor Positions:                                          OK
  /TextIter/Visible Cursor Positions:                                  OK
  /TextIter/Sentence Boundaries:                                       **
ERROR:/build/gtk+3.0-0vdXVa/gtk+3.0-3.22.18/./testsuite/gtk/textiter.c:675:check_sentence_boundaries: assertion failed (ends_sentence == gtk_text_iter_ends_sentence (&iter)): (1 == 0)
FAIL
GTester: last random seed: R02Sa9d02ec894f4a9b0298518f16ba597b5
(pid=2726)


make[5]: Entering directory '/build/gtk+3.0-0vdXVa/gtk+3.0-3.22.18/debian/build/shared/testsuite/a11y'
TEST: tree-performance... (pid=3544)
PASS: tree-performance
TEST: text... (pid=3570)
  /text/bold/GtkLabel:                                                 OK
  /text/basic/GtkLabel:                                                OK
  /text/basic/GtkEntry:                                                OK
  /text/basic/GtkTextView:                                             OK
  /text/words/GtkLabel:                                                **
ERROR:/build/gtk+3.0-0vdXVa/gtk+3.0-3.22.18/./testsuite/a11y/text.c:912:test_words: assertion failed (word == expected[i].word): ("" == "abc!")
FAIL
GTester: last random seed: R02S8b060c44049b7f2bc78ec89373735616
(pid=3586)
  /text/words/GtkEntry:                                                **
ERROR:/build/gtk+3.0-0vdXVa/gtk+3.0-3.22.18/./testsuite/a11y/text.c:912:test_words: assertion failed (word == expected[i].word): ("" == "abc!")
FAIL
GTester: last random seed: R02Sa009e1657b677f86525ff9c7de7a2bd1
(pid=3602)
  /text/words/GtkTextView:                                             **
ERROR:/build/gtk+3.0-0vdXVa/gtk+3.0-3.22.18/./testsuite/a11y/text.c:912:test_words: assertion failed (word == expected[i].word): ("" == "abc!")
FAIL

Comment 1 Jeremy Bicha 2017-08-08 02:17:18 UTC

I get the same test failures with gtk+ 3.22.17.

I am seeing similar test failures in libgtk2-perl:
http://autopkgtest.ubuntu.com/packages/libg/libgtk2-perl/artful/amd64

Let's reassign to pango since this appears to be a regression introduced there.

Comment 2 Peng Wu 2017-08-08 06:47:02 UTC

Okay, I will check the testsuite failures for pango 1.40.8 soon.

Comment 3 Peng Wu 2017-08-16 07:16:47 UTC

Created attachment 357690 [details] [review]
Fix pango_default_break function for sentence start/end

Skip the space characters in sentence start/end.

Comment 4 Peng Wu 2017-08-16 07:20:04 UTC

Sorry, I mis-understand the sentence start and sentence end.

The above patch fixed the issue.

Please review it, thanks!

Comment 5 Jeremy Bicha 2017-08-16 13:45:31 UTC

Your patches fixes the gtk3 tests for me. ☺️

I haven't tried the libgtk2-perl tests yet.

Comment 6 Jeremy Bicha 2017-08-17 16:56:44 UTC

The libgtk2-perl tests are passing now after this patch.

Comment 7 Peng Wu 2017-08-18 02:38:08 UTC

Thanks for the feedback! :)

Comment 8 Jeremy Bicha 2017-08-18 22:19:54 UTC

Matthias, you closed this bug, but the patch hasn't been committed yet.

Comment 9 Peng Wu 2017-08-22 07:19:09 UTC

Could you review and merge the patch?

Comment 10 Matthias Clasen 2017-08-30 14:17:47 UTC

Review of attachment 357690 [details] [review]:

ok

Comment 11 Matthias Clasen 2017-08-30 14:19:17 UTC

Attachment 357690 [details] pushed as 33c10cb - Fix pango_default_break function for sentence start/end

Comment 12 Peng Wu 2017-08-31 04:56:42 UTC

Thanks for the review!