After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785947 - Fix crash in passwords sync
Fix crash in passwords sync
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Sync
git master
Other Linux
: Normal critical
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 777631
 
 
Reported: 2017-08-07 13:59 UTC by Michael Catanzaro
Modified: 2017-08-08 00:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
passwords-sync: Fix crash caused by serializing NULL usernames (5.50 KB, patch)
2017-08-08 00:36 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2017-08-07 13:59:24 UTC 
Bookmarks/history/tabs sync is working well for me, but if I enable passwords sync and click Sync Now, I get this crash:

+ Trace 237782

  • #0 strlen
    at ../sysdeps/x86_64/strlen.S line 106
  • #1 json_strescape
    at ../../../../Projects/GNOME/json-glib/json-glib/json-generator.c line 87
  • #2 dump_value
    at ../../../../Projects/GNOME/json-glib/json-glib/json-generator.c line 350
  • #3 dump_node
    at ../../../../Projects/GNOME/json-glib/json-glib/json-generator.c line 317
  • #4 dump_object
    at ../../../../Projects/GNOME/json-glib/json-glib/json-generator.c line 447
  • #5 dump_node
    at ../../../../Projects/GNOME/json-glib/json-glib/json-generator.c line 326
  • #6 json_generator_to_gstring
    at ../../../../Projects/GNOME/json-glib/json-glib/json-generator.c line 504
  • #7 json_generator_to_data
    at ../../../../Projects/GNOME/json-glib/json-glib/json-generator.c line 530
  • #8 json_gobject_to_data
    at ../../../../Projects/GNOME/json-glib/json-glib/json-gobject.c line 1009
  • #9 ephy_synchronizable_default_to_bso
    at ../../../../Projects/GNOME/epiphany/lib/sync/ephy-synchronizable.c line 233
  • #10 ephy_synchronizable_to_bso
    at ../../../../Projects/GNOME/epiphany/lib/sync/ephy-synchronizable.c line 116
  • #11 ephy_sync_service_upload_synchronizable
    at ../../../../Projects/GNOME/epiphany/lib/sync/ephy-sync-service.c line 1225
  • #12 merge_collection_finished_cb
    at ../../../../Projects/GNOME/epiphany/lib/sync/ephy-sync-service.c line 1256
  • #13 merge_cb
    at ../../../../Projects/GNOME/epiphany/lib/sync/ephy-password-manager.c line 1060
  • #14 secret_service_search_cb
    at ../../../../Projects/GNOME/epiphany/lib/sync/ephy-password-manager.c line 558
  • #15 g_simple_async_result_complete
    at /home/mcatanzaro/Projects/GNOME/glib/gio/gsimpleasyncresult.c line 801
  • #16 on_search_secrets
    at /home/mcatanzaro/Projects/GNOME/libsecret/libsecret/secret-methods.c line 98
  • #17 g_simple_async_result_complete
    at /home/mcatanzaro/Projects/GNOME/glib/gio/gsimpleasyncresult.c line 801
  • #18 on_get_secrets_complete
    at /home/mcatanzaro/Projects/GNOME/libsecret/libsecret/secret-item.c line 1378
  • #19 g_task_return_now
    at /home/mcatanzaro/Projects/GNOME/glib/gio/gtask.c line 1145
  • #20 g_task_return
    at /home/mcatanzaro/Projects/GNOME/glib/gio/gtask.c line 1203
  • #21 g_task_return_pointer
    at /home/mcatanzaro/Projects/GNOME/glib/gio/gtask.c line 1601
  • #22 reply_cb
    at /home/mcatanzaro/Projects/GNOME/glib/gio/gdbusproxy.c line 2589
  • #23 g_task_return_now
    at /home/mcatanzaro/Projects/GNOME/glib/gio/gtask.c line 1145
  • #24 g_task_return
    at /home/mcatanzaro/Projects/GNOME/glib/gio/gtask.c line 1203
  • #25 g_task_return_pointer
    at /home/mcatanzaro/Projects/GNOME/glib/gio/gtask.c line 1601
  • #26 g_dbus_connection_call_done
    at /home/mcatanzaro/Projects/GNOME/glib/gio/gdbusconnection.c line 5722
  • #27 g_task_return_now
    at /home/mcatanzaro/Projects/GNOME/glib/gio/gtask.c line 1145
  • #28 complete_in_idle_cb
    at /home/mcatanzaro/Projects/GNOME/glib/gio/gtask.c line 1159
  • #29 g_idle_dispatch
    at /home/mcatanzaro/Projects/GNOME/glib/glib/gmain.c line 5500
  • #30 g_main_dispatch
    at /home/mcatanzaro/Projects/GNOME/glib/glib/gmain.c line 3148
  • #31 g_main_context_dispatch
    at /home/mcatanzaro/Projects/GNOME/glib/glib/gmain.c line 3813
  • #32 g_main_context_iterate
    at /home/mcatanzaro/Projects/GNOME/glib/glib/gmain.c line 3886
  • #33 g_main_context_iteration
    at /home/mcatanzaro/Projects/GNOME/glib/glib/gmain.c line 3947
  • #34 g_application_run
    at /home/mcatanzaro/Projects/GNOME/glib/gio/gapplication.c line 2401
  • #35 main
    at ../../../../Projects/GNOME/epiphany/src/ephy-main.c line 432 






Comment 1


Michael Catanzaro





          2017-08-08 00:36:41 UTC
        



The following fix has been pushed:
e9dbd95 passwords-sync: Fix crash caused by serializing NULL usernames






Comment 2


Michael Catanzaro





          2017-08-08 00:36:46 UTC
        



Created attachment 357165 [details] [review]
passwords-sync: Fix crash caused by serializing NULL usernames