After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785431 - element: document that gst_element_continue_state needs to be called with the STATE_LOCK
element: document that gst_element_continue_state needs to be called with the...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: documentation
git master
Other Linux
: Normal enhancement
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-26 08:21 UTC by George Kiagiadakis
Modified: 2017-07-26 10:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
element: document that gst_element_continue_state needs to be called with the STATE_LOCK (888 bytes, patch)
2017-07-26 08:21 UTC, George Kiagiadakis 		committed Details | Review

Description George Kiagiadakis 2017-07-26 08:21:30 UTC 
Created attachment 356400 [details] [review]
element: document that gst_element_continue_state needs to be called with the STATE_LOCK

gst_element_continue_state() should be called with the STATE_LOCK held, since it calls gst_element_change_state(), which requires it. Document that.
Comment 1 Sebastian Dröge (slomo) 2017-07-26 09:25:07 UTC 
Comment on attachment 356400 [details] [review]
element: document that gst_element_continue_state needs to be called with the STATE_LOCK

Who is calling continue_state() though, other than GstBin and basesink? :)
Comment 2 George Kiagiadakis 2017-07-26 09:32:17 UTC 
(In reply to Sebastian Dröge (slomo) from comment #1)
> Who is calling continue_state() though, other than GstBin and basesink? :)

The new ipcpipeline plugin I'm proposing needs to call it:
https://bugzilla.gnome.org/show_bug.cgi?id=752214
Comment 3 George Kiagiadakis 2017-07-26 09:37:15 UTC 
commit 4c3092e07a4e03171649069f1a5f2bed5991d461
Author: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date:   Wed Jul 26 11:15:58 2017 +0300

    element: document that gst_element_continue_state needs to be called with the STATE_LOCK
    
    It internally calls gst_element_change_state(), which requires the STATE_LOCK
    
    https://bugzilla.gnome.org/show_bug.cgi?id=785431