After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785407 - audioconvert: Concider channel=1, channel-mask=0x0 as mono
audioconvert: Concider channel=1, channel-mask=0x0 as mono
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-25 16:40 UTC by Thibault Saunier
Modified: 2017-07-26 13:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
audioconvert: Concider channel=1, channel-mask=0x0 as mono (1.59 KB, patch)
2017-07-25 16:40 UTC, Thibault Saunier 		none Details | Review
Since V1: (1.59 KB, patch)
2017-07-25 16:43 UTC, Thibault Saunier 		committed Details | Review

Description Thibault Saunier 2017-07-25 16:40:50 UTC 
See commit message.
Comment 1 Thibault Saunier 2017-07-25 16:40:56 UTC 
Created attachment 356371 [details] [review]
audioconvert: Concider channel=1, channel-mask=0x0 as mono

channels=1 is always mono, having it 'unpositioned' does not make
sense.

This fixes pipeline such as:

  gst-validate-1.0 audiotestsrc ! audio/x-raw,channels=2,rate=44100,layout=interleaved ! audioconvert ! audioresample ! audio/x-raw, rate=44100, channels=1 ! avenc_mp2 ! fakesink
Comment 2 Thibault Saunier 2017-07-25 16:43:03 UTC 
Created attachment 356372 [details] [review]
Since V1:

- Minor fix in commit message
Comment 3 Sebastian Dröge (slomo) 2017-07-26 06:54:40 UTC 
Comment on attachment 356372 [details] [review]
Since V1:

Might also want to add that case to gst_audio_info_from_caps()
Comment 4 Thibault Saunier 2017-07-26 13:23:45 UTC 
> Might also want to add that case to gst_audio_info_from_caps()

It is already handled there: 

 if (!gst_structure_get (str, "channel-mask", GST_TYPE_BITMASK, &channel_mask,
          NULL) || (channel_mask == 0 && channels == 1)) {