After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785387 - Possible Memory leak in acmenc.c
Possible Memory leak in acmenc.c
Status: RESOLVED INVALID
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.12.2
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-25 07:58 UTC by Satya Prakash Gupta
Modified: 2017-07-25 08:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch file is attached. (633 bytes, patch)
2017-07-25 07:58 UTC, Satya Prakash Gupta 		rejected Details | Review

Description Satya Prakash Gupta 2017-07-25 07:58:07 UTC 
Created attachment 356336 [details] [review]
Patch file is attached.

File : gst-plugins-bad/sys/acmenc/acmenc.c

Function  acmenc_register_file:

Memory leak is possible in success case  .


Solution :  g_free (params) &  g_free (name); should be freed.

++patch is attched for possible solution.

Kindly review the patch and provide your feedback.
Comment 1 Sebastian Dröge (slomo) 2017-07-25 08:21:52 UTC 
Review of attachment 356336 [details] [review]:

::: sys/acmenc/acmenc.c
@@ +596,1 @@
   return TRUE;

This is wrong. name is stored in params, and params is stored in the qdata of the type.