After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785343 - datetime: Honor location enabled setting
datetime: Honor location enabled setting
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: color
unspecified
Other All
: Normal normal
: ---
Assigned To: Richard Hughes
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2017-07-24 13:55 UTC by Rui Matos
Modified: 2017-07-24 15:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
datetime: Honor location enabled setting (4.55 KB, patch)
2017-07-24 13:55 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2017-07-24 13:55:18 UTC 
If location is disabled session wide we shouldn't use the service.
Comment 1 Rui Matos 2017-07-24 13:55:22 UTC 
Created attachment 356302 [details] [review]
datetime: Honor location enabled setting
Comment 2 Kalev Lember 2017-07-24 14:10:17 UTC 
Review of attachment 356302 [details] [review]:

::: plugins/datetime/gsd-timezone-monitor.c
@@ +339,3 @@
+
+        if (priv->geoclue_client)
+                gclue_client_call_stop (priv->geoclue_client, NULL, NULL, NULL);

I'd add 'priv->geoclue_client = NULL;' here to make sure it's safe to call stop_geoclue() repeatedly. Beyond that everything looks good to me, thanks!
Comment 3 Rui Matos 2017-07-24 15:05:55 UTC 
Amended as suggested, thanks

Attachment 356302 [details] pushed as 50aa59b - datetime: Honor location enabled setting