After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785338 - crash clicking lock icon after deleting the URL in the headerbar entry
crash clicking lock icon after deleting the URL in the headerbar entry
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
3.24.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-24 12:14 UTC by Lapo Calamandrei
Modified: 2017-07-24 20:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window: Pass address from embed to security popover (1.31 KB, patch)
2017-07-24 20:52 UTC, Michael Catanzaro 		committed Details | Review

Description Lapo Calamandrei 2017-07-24 12:14:14 UTC 
The Summary says all, I'm on a fedora 26, steps to reproduce:

- launch epiphany
- go to planet.gnome.org and let the page load
- delete the url from the headerbar entry
- click the lock icon in the aformentioned entry
Comment 1 Michael Catanzaro 2017-07-24 16:11:17 UTC 
I can reproduce:

+ Trace 237692

  • #0 ephy_security_popover_set_address
    at ephy-security-popover.c line 74
  • #1 ephy_security_popover_set_property
    at ephy-security-popover.c line 226
  • #2 object_set_property
    at gobject.c line 1423
  • #3 g_object_new_internal
    at gobject.c line 1817
  • #4 g_object_new_valist
    at gobject.c line 2042
  • #5 g_object_new
    at gobject.c line 1626
  • #6 ephy_security_popover_new
    at ephy-security-popover.c line 353
  • #7 title_widget_lock_clicked_cb
    at ephy-window.c line 2916
  • #11 <emit signal 0x7fa5643a0a24 "lock-clicked" on instance 0x562ff7810360 [EphyLocationEntry]>
    at gsignal.c line 3487
  • #12 icon_button_press_event_cb
    at ephy-location-entry.c line 721
  • #16 <emit signal ??? on instance 0x562ff7810360 [EphyLocationEntry]>
    at gsignal.c line 3447
  • #17 gtk_entry_event
    at gtkentry.c line 4292
  • #18 _gtk_marshal_BOOLEAN__BOXEDv
    at gtkmarshalers.c line 143
  • #19 _g_closure_invoke_va
    at gclosure.c line 867
  • #20 g_signal_emit_valist
    at gsignal.c line 3300
  • #21 g_signal_emit
    at gsignal.c line 3447
  • #22 gtk_widget_event_internal
    at gtkwidget.c line 7610
  • #23 gtk_widget_event
    at gtkwidget.c line 7293
  • #24 propagate_event_up
    at gtkmain.c line 2568
  • #25 propagate_event
    at gtkmain.c line 2670
  • #26 gtk_main_do_event
    at gtkmain.c line 1901
  • #27 _gdk_event_emit
    at gdkevents.c line 73
  • #28 gdk_event_source_dispatch
    at gdkeventsource.c line 124
  • #29 g_main_dispatch
    at gmain.c line 3234
  • #30 g_main_context_dispatch
    at gmain.c line 3899
  • #31 g_main_context_iterate
    at gmain.c line 3972
  • #32 g_main_context_iteration
    at gmain.c line 4033
  • #33 g_application_run
    at gapplication.c line 2381
  • #34 main
    at ephy-main.c line 432 






Comment 2


Michael Catanzaro





          2017-07-24 20:52:03 UTC
        



The following fix has been pushed:
60da25c window: Pass address from embed to security popover






Comment 3


Michael Catanzaro





          2017-07-24 20:52:06 UTC
        



Created attachment 356324 [details] [review]
window: Pass address from embed to security popover

It's wrong to try to use the address from the title widget here, because
the user could edit it to say whatever he wants, and it will crash if
there is no text in the location entry. Instead, get the address from
the web view.