After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785308 - make distcheck fails with *.Po: No such file or directory
make distcheck fails with *.Po: No such file or directory
Status: RESOLVED FIXED
Product: gparted
Classification: Other
Component: application
GIT HEAD
Other Linux
: Normal normal
: ---
Assigned To: gparted maintainers alias
gparted maintainers alias
Depends on:
Blocks:
 
 
Reported: 2017-07-23 11:05 UTC by Mike Fleetwood
Modified: 2017-08-07 17:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix make distcheck build failing with missing *.Po files (v1) (3.48 KB, patch)
2017-07-23 11:36 UTC, Mike Fleetwood
none Details | Review

Description Mike Fleetwood 2017-07-23 11:05:10 UTC
Make distcheck is failing like this:
    <snip>
    Make distcheck
    Making distclean in tests
    make[2]: Entering directory
    '/home/gedakc/workspace/gparted/gparted-0.29.0-beta1/_build/sub/tests'
    Makefile:658: ../src/.deps/BlockSpecial.Po: No such file or directory
    Makefile:659: ../src/.deps/PipeCapture.Po: No such file or directory
    make[2]: *** No rule to make target '../src/.deps/PipeCapture.Po'.  Stop.
    make[2]: Leaving directory
    '/home/gedakc/workspace/gparted/gparted-0.29.0-beta1/_build/sub/tests'
    Makefile:596: recipe for target 'distclean-recursive' failed
    make[1]: *** [distclean-recursive] Error 1
    make[1]: Leaving directory
    '/home/gedakc/workspace/gparted/gparted-0.29.0-beta1/_build/sub'
    Makefile:805: recipe for target 'distcheck' failed
    make: *** [distcheck] Error 1
Comment 1 Mike Fleetwood 2017-07-23 11:36:11 UTC
Created attachment 356224 [details] [review]
Fix make distcheck build failing with missing *.Po files (v1)

Hi Curtis,

Here's the patch for this.  Confirmed make distcheck works successfully
on Fedora 26 and CentOS 6, as the newest and oldest distros available.

Thanks,
Mike


Some of the more useful references I found discussing the issue:
1) converting to subdir-objects
http://gnu-automake.7480.n7.nabble.com/converting-to-subdir-objects-td21724.html
2) svndigest changeset 1581
http://dev.thep.lu.se/svndigest/changeset/1581
3) "make distclean" fails.
https://github.com/collectd/collectd/issues/1042
4) bug#20699: subdir-objects with source from sibling directory breaks distcheck
http://gnu-automake.7480.n7.nabble.com/bug-20699-subdir-objects-with-source-from-sibling-directory-breaks-distcheck-td21940.html
5) autotools: compiling with code from another directory
https://stackoverflow.com/questions/30379837/autotools-compiling-with-code-from-another-directory
Comment 2 Curtis Gedak 2017-07-23 16:12:04 UTC
Thank you Mike for investigating this "make distcheck" issue and developing a patch.

I confirmed that "make distcheck" works successfully on Debian 8 and Kubuntu 16.04.

Patch v1 from comment #1 has been committed to the git master branch for inclusion in the next release of GParted.

The relevant git commit can be viewed at the following link:

Fix make distcheck build failing with missing *.Po files (#785308)
https://git.gnome.org/browse/gparted/commit/?id=38cb6f2770daa8b8fb72115ba9f4bba473783928
Comment 3 Curtis Gedak 2017-08-07 17:21:42 UTC
This enhancement was included in the GParted 0.29.0 release on August 7, 2017.