GNOME Bugzilla – Bug 785176
Add an item for favorite files in the GtkPlacesSidebar
Last modified: 2017-11-05 20:08:50 UTC
see patch.
Created attachment 356054 [details] [review] placessidebar: add starred location item Add an item for showing all files marked as favorite. This item will open all files that have the nao:preddefined-tag-favorite tag
Review of attachment 356054 [details] [review]: Is it really preddefined-tag-favorite, or i the duplicate d a typo ?
(In reply to Matthias Clasen from comment #2) > Review of attachment 356054 [details] [review] [review]: > > Is it really preddefined-tag-favorite, or i the duplicate d a typo ? it is a typo in the commit message
Created attachment 357775 [details] [review] placessidebar: add starred location item Add an item for showing all files marked as favorite. This item will open all files that have the nao:predefined-tag-favorite tag
Review of attachment 357775 [details] [review]: Just minor fixes needed, looks fine to me in general. ::: gtk/gtkplacessidebar.c @@ +4492,3 @@ + * files have nao:predefined-tag-favorite + * + * Since: ... the last sentence appears a bit incomplete. It should probably say something like: In GNOME, starred files are implemented by setting the nao:predefined-tag-favorite tag in the tracker database. Since: should state the precise version in this case, e.g. 3.22.19 @@ +5331,3 @@ + * Sets whether the @sidebar should show an item for entering a location; + * this is off by default. An application may want to turn this on if manually + * entering URLs is an expected user action. Looks like a copy-pasted text from a different property - what does stars have to do with entering urls ? @@ +5336,3 @@ + * #GtkPlacesSidebar::show-starred-location signal. + * + * Since: ... Since: 3.22.19 @@ +5361,3 @@ + * Returns: %TRUE if the sidebar will display a Starred item. + * + * Since: ... 3.22.19 ::: gtk/gtkplacessidebar.h @@ +151,3 @@ gboolean gtk_places_sidebar_get_show_other_locations (GtkPlacesSidebar *sidebar); +//GDK_AVAILABLE_IN_3_... This needs to be uncommented, and should probably just be 3_22, since we don't have more precise macros
Created attachment 357896 [details] [review] placessidebar: add starred location item Add an item for showing all files marked as favorite. This item will open all files that have the nao:predefined-tag-favorite tag
Created attachment 357897 [details] [review] placessidebar: add starred location item Add an item for showing all files marked as favorite. This item will open all files that have the nao:predefined-tag-favorite tag
Review of attachment 357897 [details] [review]: thanks for the cleanups, looks ok now.
Created attachment 363018 [details] [review] The patch, updated to gtk-3-22 git. placessidebar: add starred location item Add an item for showing all files marked as favorite. This item will open all files that have the nao:predefined-tag-favorite tag
Pushed to gtk-3-22 and master