After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785034 - secret_value_unref shouldn't be annotated (allow-none)
secret_value_unref shouldn't be annotated (allow-none)
Status: RESOLVED FIXED
Product: libsecret
Classification: Other
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: libsecret maintainer(s)
libsecret maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-07-17 17:40 UTC by Debarshi Ray
Modified: 2017-07-18 14:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
secret-value: Don't annotate secret_value_unref as (allow-none) (859 bytes, patch)
2017-07-17 17:42 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2017-07-17 17:40:01 UTC 
secret_value_unref's value argument is annotated as (allow-none). However, the function itself has an assertion against NULL values. Since most _unref methods in GLib don't accept NULL parameters (eg., g_object_unref, g_hash_table_unref), we should probably drop the (allow-node) for consistency.
Comment 1 Debarshi Ray 2017-07-17 17:42:09 UTC 
Created attachment 355773 [details] [review]
secret-value: Don't annotate secret_value_unref as (allow-none)
Comment 2 Stef Walter 2017-07-18 10:48:09 UTC 
Looks good. accepted-commit-now
Comment 3 Debarshi Ray 2017-07-18 14:02:55 UTC 
Comment on attachment 355773 [details] [review]
secret-value: Don't annotate secret_value_unref as (allow-none)

Thanks for the review. Pushed to master.