After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784883 - [PATCH] build: use APPSTREAM_XML instead of APPDATA_XML
[PATCH] build: use APPSTREAM_XML instead of APPDATA_XML
Status: RESOLVED FIXED
Product: shotwell
Classification: Other
Component: build
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Shotwell Maintainers
Shotwell Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-12 23:53 UTC by Brian Masney
Modified: 2017-08-13 17:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.59 KB, patch)
2017-07-12 23:53 UTC, Brian Masney 		committed Details | Review
fix rules for appstream files (1.10 KB, patch)
2017-08-13 09:47 UTC, Thomas Moschny 		committed Details | Review

Description Brian Masney 2017-07-12 23:53:34 UTC 
Created attachment 355471 [details] [review]
Patch

According to commit 8c0c9ec747bc in the appstream-glib project
(https://github.com/hughsie/appstream-glib/commit/8c0c9ec747bc6d1e8ca232d0068018b5157fd914), APPDATA_XML has been deprecated and APPSTREAM_XML should be used insted. Fedora 26 no longer ships with appdata-xml.m4 in the libappstream-glib-devel package. This patch converts the build system to use APPSTREAM_XML.
Comment 1 Jens Georg 2017-07-13 05:44:09 UTC 
Review of attachment 355471 [details] [review]:

+1
Comment 2 Thomas Moschny 2017-08-13 09:47:22 UTC 
Created attachment 357511 [details] [review]
fix rules for appstream files

The patch is incomplete. The appdata file is neither created nor installed, as the rules in @APPSTREAM_XML_RULES@ expect files to be listed in $(appstream_XML) rather than in $(appdata_XML).

Patch for master attached. This affects also the 0.26 branch, and especially the 0.26.3 release.