GNOME Bugzilla – Bug 78484
modules with xmldocs.make bug
Last modified: 2004-12-22 21:47:04 UTC
Here is a list of modules with the spaces instead of tabs bug in xmldocs.make or sgmldocs.make. It is based on the modules I checked out, so is not necessarily complete: ./gnome-utils/sgmldocs.make ./gnome-utils/xmldocs.make ./nautilus/help/sgmldocs.make ./nautilus/help/xmldocs.make ./gnome-core/sgmldocs.make ./gnome-core/xmldocs.make ./glade/doc/xmldocs.make ./gnome-desktop/sgmldocs.make ./gnome-desktop/xmldocs.make ./gnome-panel/sgmldocs.make ./gnome-panel/xmldocs.make ./gnome-session/sgmldocs.make ./gnome-session/xmldocs.make ./gnome-games/sgmldocs.make ./gnome-control-center/help/xmldocs.make ./bug-buddy/xmldocs.make Is there a better component to submit bugs for problems in these cut-n-pasted documentation related make rules?
This is a fine place to file it. Adding Dan Mueth and Jody Goldberg to the cc list - they've got a meta-fix in progress.
adding Chris Lyttle to the cc list Chris, you've been fixing a lot of these - could you note which ones are already taken care of?
I dont know anything about a spaces instead of tabs bug, but I have disabled sgml docs and installed the new xmldocs.make in the following packages. bug-buddy gnome-games nautilus gnome-panel gnome-media gnome-terminal gnome-system-monitor I believe also that gnome-utils, control-center, Eog, gedit, gnome-applets and the users guide are done. If someone could give some more details about what this bug is/does so I can check it that'd be great.
The following rule in both xmldocs.make and sgmldocs.make uses spaces to indent the code in the rule, instead of tabs: $(docname).xml: $(entities) -ourdir=`pwd`; \ cd $(srcdir); \ cp $(entities) $$ourdir Because spaces have been used, the above rule is equivalent to: $(docname).xml: $(entities) -ourdir=`pwd`; cd $(srcdir); cp $(entities) $$ourdir -ourdir is not a valid makefile variable, which raises an error with newer versions of automake (even with older versions of automake, the rule won't get executed correctly.
I checked this out and the current list of packages with this bug is; gnome-session gnome-applets gnome-control-center glade eog gedit gnumeric I have deliberately left out the ones with the bug in sgmldocs.make as this should now be disabled for gnome2. Will post this to the gnome-docs list too
Excuse me my ignorance, but where can up to date xmldocs.make be found? I'm looking at the current xmldocs.make in galeon HEAD, and in addition to the space problems mentioned above, it also contains errors that make building documentation outside source directory fail. For example: -cp $(srcdir)/$(xml_files) $(DESTDIR)$(docdir) expands to: -cp /some/dir/file1.xml file2.xml file3.xml /install/dir I guess you can see the problem there. Furthermore, why are the rules constructed so that they are allowed to fail? This doesn't make sense to me. It only helps to hide errors in build process. I don't think any automake-generated rules generally ignore errors this way, for example. Similarly it is considered alright for installation to fail. What's the point in that?
Created attachment 10899 [details] [review] This patch should fix building outside source directory
The most recent xmldocs.make template is in gnome-docu/gdp/gdp-example2
Ok, it seems to already have the updates I was suggesting. Nevermind.
Closing then.