After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784815 - Map G_NOTIFICATION_PRIORITY_HIGH to NOTIFY_URGENCY_NORMAL
Map G_NOTIFICATION_PRIORITY_HIGH to NOTIFY_URGENCY_NORMAL
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other All
: Normal minor
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2017-07-11 19:40 UTC by Adrian Perez
Modified: 2017-07-18 21:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] Map G_NOTIFICATION_PRIORITY_HIGH to NOTIFY_URGENCY_NORMAL (1.10 KB, patch)
2017-07-11 19:40 UTC, Adrian Perez
committed Details | Review

Description Adrian Perez 2017-07-11 19:40:19 UTC
Created attachment 355344 [details] [review]
[PATCH] Map G_NOTIFICATION_PRIORITY_HIGH to NOTIFY_URGENCY_NORMAL

Provided that the difference between G_NOTIFICATION_PRIORITY_HIGH
and NORMAL is minor, it may make more sense to map the HIGH value
to libnotify's NOTIFY_URGENCY_NORMAL.

For example, this change would avoid people having to manually
dismiss notifications from applications which use HIGH, because
notification daemons which use the libnotify urgency values tend
to treat the NOTIFY_URGENCY_CRITICAL in a way much louder than
GNOME Shell would treat G_NOTIFICATION_PRIORITY_HIGH.
Comment 1 Adrian Perez 2017-07-11 19:43:25 UTC
Related issue: https://github.com/aperezdc/revolt/issues/67
Comment 2 Matthias Clasen 2017-07-13 21:24:39 UTC
Review of attachment 355344 [details] [review]:

Ok, lets try this. We'll see if it breaks other apps expectations, I guess.