After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784495 - souphttpsrc: soup session sharing cannot cover multi-streams
souphttpsrc: soup session sharing cannot cover multi-streams
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-04 05:31 UTC by Seungha Yang
Modified: 2017-07-04 06:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
souphttpsrc: Unset limit on the number of connection if soup (1.34 KB, patch)
2017-07-04 06:09 UTC, Seungha Yang
none Details | Review
souphttpsrc: Unset limit on the number of connection if soup session sharing is used (1.34 KB, patch)
2017-07-04 06:10 UTC, Seungha Yang
committed Details | Review

Description Seungha Yang 2017-07-04 05:31:00 UTC
libsoup defines default value of SOUP_SESSION_MAX_CONNS_PER_HOST as "2". Some adaptivestreams, however, requires more connection if we want to share session.
(e.g., multi audio/subtitle streams).
Comment 1 Seungha Yang 2017-07-04 05:35:37 UTC
Following stream could be played since it has two audio track. Although not linked stream will be stopped after pipeline configure, initially more connection is required.
http://dash.akamaized.net/dash264/TestCases/10a/1/iis_forest_short_poem_multi_lang_480p_single_adapt_aaclc_sidx.mpd

What is optimal approach to fix this? Do we need to use "max-conns-per-host" property of soup depending on the number of required connection? or new session?
Comment 2 Sebastian Dröge (slomo) 2017-07-04 05:44:35 UTC
We should probably set this value to infinity for our sessions. Do you want to provide a patch?
Comment 3 Seungha Yang 2017-07-04 05:46:26 UTC
(In reply to Sebastian Dröge (slomo) from comment #2)
> We should probably set this value to infinity for our sessions. Do you want
> to provide a patch?

Sure, I'll prepare it
Comment 4 Seungha Yang 2017-07-04 06:09:47 UTC
Created attachment 354864 [details] [review]
souphttpsrc: Unset limit on the number of connection if soup

Soup allows only up to two connections per host in a session,
if we use default value. When session sharing is used, however,
more connections might be require in a session.
(e.g., multi-audio adaptive streaming case)
Comment 5 Seungha Yang 2017-07-04 06:10:42 UTC
Created attachment 354865 [details] [review]
souphttpsrc: Unset limit on the number of connection if soup session sharing is used
Comment 6 Sebastian Dröge (slomo) 2017-07-04 06:14:12 UTC
Attachment 354865 [details] pushed as b0f09d4 - souphttpsrc: Unset limit on the number of connection if soup session sharing is used