After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784484 - rtprtxreceive: Add memory and boundary checks
rtprtxreceive: Add memory and boundary checks
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-03 18:15 UTC by Nicolas Dufresne (ndufresne)
Modified: 2017-07-04 14:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rtprtxreceive: Add memory and boudary checks (2.68 KB, patch)
2017-07-03 18:15 UTC, Nicolas Dufresne (ndufresne)
committed Details | Review

Description Nicolas Dufresne (ndufresne) 2017-07-03 18:15:40 UTC
rtprtxreceive does not check if the RTP buffers and it's payload is valid.
Comment 1 Nicolas Dufresne (ndufresne) 2017-07-03 18:15:45 UTC
Created attachment 354849 [details] [review]
rtprtxreceive: Add memory and boudary checks

This element was not checking if mapping the RTP buffer and the payload
worked, and was not checking if the RTX payload was large enough.
Comment 2 Nicolas Dufresne (ndufresne) 2017-07-04 13:58:40 UTC
Thanks for the review.

Attachment 354849 [details] pushed as bf5cbce - rtprtxreceive: Add memory and boudary checks