After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784391 - keyboard: Don't create shortcuts editor twice
keyboard: Don't create shortcuts editor twice
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
unspecified
Other All
: Normal normal
: ---
Assigned To: Rui Matos
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-06-30 16:11 UTC by Florian Müllner
Modified: 2017-07-05 12:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: Don't create shortcuts editor twice (1.10 KB, patch)
2017-06-30 16:11 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2017-06-30 16:11:06 UTC 
See patch.
Comment 1 Florian Müllner 2017-06-30 16:11:10 UTC 
Created attachment 354739 [details] [review]
keyboard: Don't create shortcuts editor twice

We are accidentally creating two editors, leaking the first instance ...
Comment 2 Georges Basile Stavracas Neto 2017-07-05 12:22:07 UTC 
Review of attachment 354739 [details] [review]:

Nice catch.
Comment 3 Georges Basile Stavracas Neto 2017-07-05 12:25:26 UTC 
Attachment 354739 [details] pushed as 84d5276 - keyboard: Don't create shortcuts editor twice