After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784356 - keyboard: Fix a memory leak
keyboard: Fix a memory leak
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
3.24.x
Other All
: Normal normal
: ---
Assigned To: Rui Matos
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-06-29 18:02 UTC by Florian Müllner
Modified: 2017-07-05 12:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: Fix a memory leak (1.32 KB, patch)
2017-06-29 18:02 UTC, Florian Müllner 		committed Details | Review
keyboard: Fix another memory leak (1.34 KB, patch)
2017-06-30 16:10 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2017-06-29 18:02:44 UTC 
Drive-by fix while working on the panel.
Comment 1 Florian Müllner 2017-06-29 18:02:51 UTC 
Created attachment 354700 [details] [review]
keyboard: Fix a memory leak

While the actual strings returned by g_variant_get_strv() are owned
by the variant, we still need to free the container ...
Comment 2 Georges Basile Stavracas Neto 2017-06-30 00:26:27 UTC 
Review of attachment 354700 [details] [review]:

A leak that was hunting this code for years now. Thanks!
Comment 3 Georges Basile Stavracas Neto 2017-06-30 00:27:24 UTC 
Attachment 354700 [details] pushed as 870fb46 - keyboard: Fix a memory leak
Comment 4 Florian Müllner 2017-06-30 16:10:41 UTC 
Created attachment 354738 [details] [review]
keyboard: Fix another memory leak

The memory leak fixed in commit 870fb462019 is still present in
a copy-pasted version of the function, apply the same fix there
as well ...
Comment 5 Georges Basile Stavracas Neto 2017-07-05 01:56:39 UTC 
Review of attachment 354738 [details] [review]:

++
Comment 6 Georges Basile Stavracas Neto 2017-07-05 12:18:29 UTC 
Attachment 354738 [details] pushed as eed7431 - keyboard: Fix another memory leak