After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784221 - Build fixes
Build fixes
Status: RESOLVED FIXED
Product: libdmapsharing
Classification: Other
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: W. Michael Petullo
W. Michael Petullo
Depends on:
Blocks:
 
 
Reported: 2017-06-26 15:30 UTC by Bastien Nocera
Modified: 2017-06-27 02:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Fix running "autogen.sh" when srcdir != builddir (1.25 KB, patch)
2017-06-26 15:30 UTC, Bastien Nocera 		none Details | Review
lib: Fix gir generation with srcdir != builddir (959 bytes, patch)
2017-06-26 15:30 UTC, Bastien Nocera 		none Details | Review
build: Remove unset and empty INCLUDES variable (817 bytes, patch)
2017-06-26 15:30 UTC, Bastien Nocera 		none Details | Review

Description Bastien Nocera 2017-06-26 15:30:28 UTC 
.
Comment 1 Bastien Nocera 2017-06-26 15:30:32 UTC 
Created attachment 354515 [details] [review]
build: Fix running "autogen.sh" when srcdir != builddir

As is the default for jhbuild.
Comment 2 Bastien Nocera 2017-06-26 15:30:37 UTC 
Created attachment 354516 [details] [review]
lib: Fix gir generation with srcdir != builddir

The generated enums file will live in builddir, not srcdir:

libdmapsharing/dmap.h:11:10: fatal error: libdmapsharing/dmap-enums.h: No such file or directory
 #include <libdmapsharing/dmap-enums.h>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Comment 3 Bastien Nocera 2017-06-26 15:30:43 UTC 
Created attachment 354517 [details] [review]
build: Remove unset and empty INCLUDES variable
Comment 4 W. Michael Petullo 2017-06-26 16:02:30 UTC 
Merged and pushed to master. I hope to test and push a new release tonight.
Comment 5 W. Michael Petullo 2017-06-27 02:40:41 UTC 
Fixed in 2.9.39.