GNOME Bugzilla – Bug 784097
meson build port flags fixes
Last modified: 2017-06-23 06:34:14 UTC
Created attachment 354252 [details] [review] Fied meson build port flags A symbol visibility map file has been created for ld and the invalid libtool flag has been removed. All CFLAGS and LDFLAGS that can be enabled by using meson options have also been removed.
Review of attachment 354252 [details] [review]: Rest looks fine. ::: meson.build @@ -59,3 @@ config_h.set('HAVE_UNISTD_H', cc.has_header('unistd.h')) -# Compiler flags I don't think those changes are necessary.
meson adds by default '-Wall' and '-Winvalid-pch' at warning level 1, '-Wextra' at level 2 and finally '-Wpedantic' al level 3. Although it's true that any developer may just want those flags at any warning level, I've thought that it would be good idea to take advantage of the available meson options, in the same way as linker flags' options. Hence, I've removed all the flags already included in those levels. Do you think that the original flags should be restored?
(In reply to Iñigo Martínez from comment #2) > meson adds by default '-Wall' and '-Winvalid-pch' at warning level 1, > '-Wextra' at level 2 and finally '-Wpedantic' al level 3. > > Although it's true that any developer may just want those flags at any > warning level, I've thought that it would be good idea to take advantage of > the available meson options, in the same way as linker flags' options. > Hence, I've removed all the flags already included in those levels. > > Do you think that the original flags should be restored? I don't think you should change them in a completely unrelated patch.
Created attachment 354258 [details] [review] Fixed meson build port flags
Created attachment 354259 [details] [review] Removed flags available as meson options
(In reply to Bastien Nocera from comment #3) > (In reply to Iñigo Martínez from comment #2) > > meson adds by default '-Wall' and '-Winvalid-pch' at warning level 1, > > '-Wextra' at level 2 and finally '-Wpedantic' al level 3. > > > > Although it's true that any developer may just want those flags at any > > warning level, I've thought that it would be good idea to take advantage of > > the available meson options, in the same way as linker flags' options. > > Hence, I've removed all the flags already included in those levels. > > > > Do you think that the original flags should be restored? > > I don't think you should change them in a completely unrelated patch. I agree with you. I have split the patch in two :)