GNOME Bugzilla – Bug 784005
tests: Fixes for souphttpsrc SSL test
Last modified: 2017-10-19 12:07:03 UTC
(patches incoming)
Created attachment 354106 [details] [review] [PATCH 1/4] tests: souphttpsrc: Update test-cert.pem Recent GnuTLS disregards the Common Name and only looks at the Subject Alternative Name extension. Since our test-cert has no SAN extension, validation fails. Generate a new certificate with SAN. In addition to 127.0.0.1, for good measure make it valid for localhost and ::1, too.
Created attachment 354107 [details] [review] tests: souphttpsrc: Make ssl_cert/key_file static Just a bit of cleanup.
Created attachment 354108 [details] [review] [PATCH 3/4] tests: souphttpsrc: Avoid deprecated server ssl properties The ssl-cert-file and ssl-key-file properties are deprecated. Use the soup_server_set_ssl_cert_file function to load the files.
Created attachment 354109 [details] [review] [PATCH 4/4] tests: souphttpsrc: Avoid deprecated ssl-ca-file property SoupSession's ssl-ca-file property is deprecated. Use the recommended tls-database property. This is a bit more complex as it requires creating a GTlsFileDatabase object for an absolute (!) path to the CA certificates file.
(In reply to Jan Alexander Steffens (heftig) from comment #1) It's also possible that the SAN stuff is a red herring and GnuTLS doesn't like SHA1, since the new cert uses SHA256.
Thanks. All patches looked good and they also fixes the souphttpsrc failing test. e63a12c77d6ff74b6d0c410ec2453bd9688ca065 tests: souphttpsrc: Update test-cert.pem 27a0ea8cf54f580f2babb03ddadccb7ea7616f56 tests: souphttpsrc: Make ssl_cert/key_file static 9922091f1b50bf6c48ffb25be4e3bccabcee209c tests: souphttpsrc: Avoid deprecated server ssl properties aa8ac28d86a5c45314a6d62cfd579842f8aecad2 tests: souphttpsrc: Avoid deprecated ssl-ca-file property Attachment 354107 [details] pushed as 27a0ea8 - tests: souphttpsrc: Make ssl_cert/key_file static
Can you also add this patchset to 1.12?