GNOME Bugzilla – Bug 783975
Top panel: Transparency doesn't update on "Hide all normal windows" action.
Last modified: 2017-07-05 14:50:38 UTC
This is regarding the new top panel transparency when 'free floating'. The panel's opacity is not properly updated when windows are hidden/shown with a shortcut. Steps to reproduce: 1) Enable the "Hide all normal windows" shortcut (e.g. Super+d) 2) Maximize a window, so that the top panel becomes opaque. 3) Hit "Super+d", the desktop should be showing now, but the top panel remains opaque. More symptoms: 4) Use Ctrl+Alt+down to move to the next workspace. Now the transparency is updated. 5) Move back to the previous workspace. 6) Hit "Super+d" again to restore the window. The panel remains transparent, while it should be opaque. Solution: Probably adding a new signal that updates on windows restacked/focus or similar might help with this.
Created attachment 354088 [details] [review] panel: Consider visibility changes for solid style We currently assume that window state changes are accompanied by an allocation change (triggered for example by the minimize animation). However this misses the case where a window actor is simply hidden without any transition, as is the case with the 'show-desktop' action for instance, so start tracking plain visibility changes as well.
Thanks for the patch. It's working fine here. For anyone interested, I 'backported' this as an extension. https://github.com/franglais125/panel-transparency
What is the the way forward for this patch? Will it be included eventually in master? It would be a shame for the patch to simply rot here :)
(In reply to franglais125 from comment #3) > What is the the way forward for this patch? Will it be included eventually > in master? Yes, but it should get reviewed first - the person most likely to do that is currently on vacation :-)
Review of attachment 354088 [details] [review]: looks fine
Attachment 354088 [details] pushed as 292ac41 - panel: Consider visibility changes for solid style