After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783780 - [Negotiate] Can't access sites that request closing the connection during 401
[Negotiate] Can't access sites that request closing the connection during 401
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: Misc
2.58.x
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on: 782940 783781
Blocks:
 
 
Reported: 2017-06-14 10:04 UTC by Tomas Popela
Modified: 2017-06-22 13:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (2.64 KB, patch)
2017-06-14 10:05 UTC, Tomas Popela
reviewed Details | Review

Description Tomas Popela 2017-06-14 10:04:01 UTC
When a 401 message is received, a new token is generated and saved in the SoupNegotiateConnectionState's respose header. Later when the connection is closed (as requested by the server), the state is destroyed together with the response header. When a new request is being created and we are asked for the connection authorization, the newly created connection state doesn't have it set. At this point if the connection state is newly created, generate a new token together with the response header that will be returned as the connection authorization.

Also modify how the warning from the soup_gss_build_response is printed to differentiate if there was a failure during soup_gss_client_init or soup_gss_client_step.
Comment 1 Tomas Popela 2017-06-14 10:05:29 UTC
Created attachment 353736 [details] [review]
Proposed patch
Comment 2 Dan Winship 2017-06-19 13:47:01 UTC
Comment on attachment 353736 [details] [review]
Proposed patch

ok, looks good I think
Comment 3 Tomas Popela 2017-06-22 13:55:38 UTC
Fixed with commit 1d532c8e in the master branch.