After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783581 - multifilesrc: Implement URI interface
multifilesrc: Implement URI interface
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-06-09 08:06 UTC by Dimitrios Katsaros
Modified: 2018-01-23 18:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for miltifilesrc uri interface (3.40 KB, patch)
2017-06-09 08:09 UTC, Dimitrios Katsaros
none Details | Review
Updated verison (3.22 KB, patch)
2017-06-15 11:44 UTC, Dimitrios Katsaros
none Details | Review
Reuploading to set old version as obsolete (3.22 KB, patch)
2017-06-15 11:47 UTC, Dimitrios Katsaros
committed Details | Review

Description Dimitrios Katsaros 2017-06-09 08:06:34 UTC
With this patch we can now provide a set of files
created by multifilesink as a source for uri elements.

e.g. gst-launch-1.0 playbin uri=multifile://img%25d.ppm

Note that for the %d pattern you need to replace % with %25.
This is to be compliant with URL naming standards.

splitfilesrc also implements the URI interface. However, the pattern matching scheme it uses is not the same as multifilesrc. Thus with this we can get the added handling of multifilesrc.
Comment 1 Dimitrios Katsaros 2017-06-09 08:09:14 UTC
Created attachment 353441 [details] [review]
Patch for miltifilesrc uri interface
Comment 2 Dimitrios Katsaros 2017-06-15 11:44:04 UTC
Created attachment 353817 [details] [review]
Updated verison

I changed the uri extraction to use the gstURI API instead. This is because with the previous version URIs in the form multifile:/path/to/file rather than multifile:///path/to/file were not being handled correctly.
Comment 3 Dimitrios Katsaros 2017-06-15 11:47:26 UTC
Created attachment 353818 [details] [review]
Reuploading to set old version as obsolete
Comment 4 Tim-Philipp Müller 2018-01-23 18:49:59 UTC
commit a5b5451d934e801e4a76a3803acc44b46a9afce7 (HEAD -> master)
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Tue Jan 23 18:37:09 2018 +0000

    multifilesrc: fix up uri handler a little
    
    Fix path escaping when creating URI from location in get_uri().
    
    Return FALSE with an error when URI can't be parsed in set_uri().
    
    https://bugzilla.gnome.org/show_bug.cgi?id=783581

commit dccfaf2e91a4a7b227d9193623344eb634aada5b
Author: Dimitrios Katsaros <patcherwork@gmail.com>
Date:   Thu Jun 15 13:37:28 2017 +0200

    multifilesrc: implement uri handler
    
    With this patch we can now provide a set of files
    created by multifilesink as a source for uri elements.
    
    e.g. gst-launch-1.0 playbin uri=multifile://img%25d.ppm
    
    Note that for the %d pattern you need to replace % with %25.
    This is to be compliant with URL naming standards.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=783581