After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783555 - Remove Meego-specific code
Remove Meego-specific code
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: tracker-general
tracker-general
Depends on:
Blocks:
 
 
Reported: 2017-06-08 16:43 UTC by Sam Thursfield
Modified: 2017-11-30 08:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove Maemo/Meego leftovers (96.69 KB, patch)
2017-06-08 16:44 UTC, Sam Thursfield 		committed Details | Review
functional-tests: Unbreak test by removing haveMaemo conditionals (1.86 KB, patch)
2017-11-29 07:48 UTC, Debarshi Ray 		accepted-commit_now Details | Review

Description Sam Thursfield 2017-06-08 16:43:59 UTC 
As discussed on the mailing list: https://mail.gnome.org/archives/tracker-list/2017-May/msg00006.html
Comment 1 Sam Thursfield 2017-06-08 16:44:24 UTC 
Created attachment 353407 [details] [review]
Remove Maemo/Meego leftovers

This removes various code paths that we believe to be unused.

  * The userguides miner has been removed altogether.
  * The application miner no longer parses MeeGo-style .desktop files
  * The TRACKER_DISABLE_MEEGOTOUCH_LOCALE environment flag is gone
    (it already did nothing)
  * Character set detection with libmeegotouch is removed, only enca
    or libicu are supported
  * Meego-specific flags are gone from .desktop files
  * Functional tests have lost their vestigal Scratchbox and Aegis support

There are 5 ontologies referencing Maemo, 4 of which are largely unused.
These have been kept around in case anyone is using them outside
Tracker.
Comment 2 Carlos Garnacho 2017-06-08 22:22:06 UTC 
Comment on attachment 353407 [details] [review]
Remove Maemo/Meego leftovers

Sweeeet :)
Comment 3 Sam Thursfield 2017-06-09 12:26:05 UTC 
Review of attachment 353407 [details] [review]:

Thanks for reviewing! Committed as 809b56767fccd5680136485c6fbbc895e83dd886
Comment 4 Debarshi Ray 2017-11-28 20:37:01 UTC 
tracker-miners.git still has two references to haveMaemo in tests/functional-tests/01-insertion.py. When running the test it leads to:

Traceback (most recent call last):

+ Trace 238198

  • File "./01-insertion.py", line 774 in <module> 
    class TrackerStorePhoneNumberTest (CommonTrackerStoreTest):
  • File "./01-insertion.py", line 780 in TrackerStorePhoneNumberTest 
    @ut.skipIf (not cfg.haveMaemo, "This test uses maemo:specific properties")
AttributeError: 'module' object has no attribute 'haveMaemo' 






Comment 5


Debarshi Ray





          2017-11-29 07:48:24 UTC
        



Created attachment 364601 [details] [review]
functional-tests: Unbreak test by removing haveMaemo conditionals






Comment 6


Sam Thursfield





          2017-11-29 11:37:17 UTC
        



Review of attachment 364601 [details] [review]:

Looks correct, thanks!






Comment 7


Sam Thursfield





          2017-11-29 11:37:46 UTC
        



Committed as 001e727d68b289a03d6ae6ecc655417387c5df94






Comment 8


Carlos Garnacho





          2017-11-29 11:39:32 UTC
        



Review of attachment 364601 [details] [review]:

Looks good!






Comment 9


Debarshi Ray





          2017-11-29 12:28:30 UTC
        



Thanks for the fast turnaround!






Comment 10


Debarshi Ray





          2017-11-30 08:23:52 UTC
        



(In reply to Sam Thursfield from comment #7)
> Committed as 001e727d68b289a03d6ae6ecc655417387c5df94

The same test, 01-insertion.py, is also present in tracker-miners.git. Maybe it should be removed?