After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783512 - Resetting the ChangedFlags of MetaBackgroundActor is needed
Resetting the ChangedFlags of MetaBackgroundActor is needed
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2017-06-07 14:17 UTC by Hyungwon Hwang
Modified: 2017-08-21 20:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
MetaBackgroundActor: Reset ChangedFlags after it is used (903 bytes, patch)
2017-06-07 14:19 UTC, Hyungwon Hwang 		none Details | Review
meta-background-actor: Unset flags when they are not valid anymore (1.40 KB, patch)
2017-08-21 19:45 UTC, Alessandro Bono 		committed Details | Review

Description Hyungwon Hwang 2017-06-07 14:17:47 UTC 
Resetting the ChangedFlags is needed after it is used. Without resetting it, Cogl pipeline setting code runs repeatedly.
Comment 1 Hyungwon Hwang 2017-06-07 14:19:29 UTC 
Created attachment 353328 [details] [review]
MetaBackgroundActor: Reset ChangedFlags after it is used
Comment 2 Alessandro Bono 2017-08-21 19:45:22 UTC 
Created attachment 358090 [details] [review]
meta-background-actor: Unset flags when they are not valid anymore

Currently, the flags that describe what is changed are never unsetted.
Unset each flag just after using them.
Comment 3 Florian Müllner 2017-08-21 20:11:55 UTC 
Review of attachment 358090 [details] [review]:

LGTM
Comment 4 Alessandro Bono 2017-08-21 20:19:48 UTC 
Comment on attachment 358090 [details] [review]
meta-background-actor: Unset flags when they are not valid anymore

Attachment 358090 [details] pushed as 1684798 - meta-background-actor: Unset flags when they are not valid anymore