GNOME Bugzilla – Bug 783483
Remove explicit destroy of label/entry children
Last modified: 2017-06-06 19:40:22 UTC
See attached patches.
Created attachment 353264 [details] [review] Remove dangerous explicit destroy There's no need to explicitly destroy the ClutterText actor inside the label; doing so is actually harmful, as it will break the normal reference cycle between container and children. As StLabel doesn't hold any extra reference to the ClutterText actor and just uses clutter_actor_add_actor() to add it to itself, let the normal container dispose cycle run to dispose of the reference.
Created attachment 353265 [details] [review] Remove an explicit destroy to the ClutterText actor This is the same as the previous commit, but for StEntry. We don't have any need to explicitly destroy this actor in our dispose implementation, and doing so breaks the assumption that we can access the clutter_text from within destroy.
Review of attachment 353264 [details] [review]: LGTM
Review of attachment 353265 [details] [review]: LGTM
Attachment 353264 [details] pushed as ad2cb22 - Remove dangerous explicit destroy Attachment 353265 [details] pushed as e2838a7 - Remove an explicit destroy to the ClutterText actor