After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783343 - Wayland: RFC - add shortcut inhibitor support
Wayland: RFC - add shortcut inhibitor support
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Wayland
3.22.x
Other Linux
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-06-02 09:29 UTC by Olivier Fourdan
Modified: 2017-08-02 11:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] wayland: add shortcut inhibitor support (7.62 KB, patch)
2017-06-02 09:31 UTC, Olivier Fourdan
none Details | Review
[PATCH v2] wayland: add shortcut inhibitor support (8.05 KB, patch)
2017-07-11 16:12 UTC, Olivier Fourdan
none Details | Review
[PATCH v3] wayland: add shortcut inhibitor support (8.71 KB, patch)
2017-07-25 14:29 UTC, Olivier Fourdan
committed Details | Review

Description Olivier Fourdan 2017-06-02 09:29:25 UTC
The following series of patch aims at implementing support for keyboard shortcut inhibitor support in gtk+

This protocol has been previously discussed here:

https://lists.freedesktop.org/archives/wayland-devel/2017-March/033526.html
https://lists.freedesktop.org/archives/wayland-devel/2017-April/033638.html
https://lists.freedesktop.org/archives/wayland-devel/2017-April/033800.html
https://lists.freedesktop.org/archives/wayland-devel/2017-May/034130.html
https://lists.freedesktop.org/archives/wayland-devel/2017-June/034223.html

Note: This protocol is still under review/discussion on wayland-devel mailing and may be subject to change before it's approved in wyland-protocol, the patch  posted here is for reference and preliminary discussions.

This requires the protocol to be implemented in mutter as well, see bug 783342
Comment 1 Olivier Fourdan 2017-06-02 09:31:22 UTC
Created attachment 353063 [details] [review]
[PATCH] wayland: add shortcut inhibitor support
Comment 2 Olivier Fourdan 2017-07-11 16:12:22 UTC
Created attachment 355340 [details] [review]
[PATCH v2] wayland: add shortcut inhibitor support

This adds support for the shortcut inhibitor protocol in gdk/wayland
backend.

A shortcut inhibitor request is issued from the gdk wayland backend for
both the older, deprecated API gdk_device_grab() and the new gdk seat
API gdk_seat_grab(), but only if the requested capability is for the
keyboard only.
Comment 3 Olivier Fourdan 2017-07-25 14:29:09 UTC
Created attachment 356364 [details] [review]
[PATCH v3] wayland: add shortcut inhibitor support

v3: Add dependency on wayland-protocols 1.9 (which includes the shortcut inhibitor protocol)
Comment 4 Olivier Fourdan 2017-08-02 09:43:48 UTC
Carlos, you're okay with me landing this patch? gtk-3-22 and master or just gtk-3-22?
Comment 5 Carlos Garnacho 2017-08-02 10:27:35 UTC
Comment on attachment 356364 [details] [review]
[PATCH v3] wayland: add shortcut inhibitor support

Looks good! Please push to gtk-3-22 and master :)
Comment 6 Olivier Fourdan 2017-08-02 11:16:04 UTC
Comment on attachment 356364 [details] [review]
[PATCH v3] wayland: add shortcut inhibitor support

attachment 356364 [details] [review] pushed to git master as commit ac61aed - wayland: add shortcut inhibitor support

attachment 356364 [details] [review] pushed to branch gtk-3-22 as commit 1c23bce - wayland: add shortcut inhibitor support