After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783210 - build: Switch to sassc for generating style
build: Switch to sassc for generating style
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-05-29 19:06 UTC by Florian Müllner
Modified: 2017-05-30 10:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Switch to sassc for generating style (14.11 KB, patch)
2017-05-29 19:06 UTC, Florian Müllner 		committed Details | Review
build: Switch to sassc for generating style (7.43 KB, patch)
2017-05-29 19:08 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2017-05-29 19:06:43 UTC 
See patches (2nd one is for the gnome-shell-extensions module)
Comment 1 Florian Müllner 2017-05-29 19:06:47 UTC 
Created attachment 352817 [details] [review]
build: Switch to sassc for generating style

GTK+ switched from ruby-based sass to c-based sassc for performance
reasons. It makes sense to follow suit, if not to not require two
tools for the same job ...
Comment 2 Florian Müllner 2017-05-29 19:08:47 UTC 
Created attachment 352818 [details] [review]
build: Switch to sassc for generating style

GTK+ switched from ruby-based sass to c-based sassc for performance
reasons. It makes sense to follow suit, if not to not require two
tools for the same job ...
Comment 3 Rui Matos 2017-05-30 10:38:26 UTC 
Review of attachment 352817 [details] [review]:

lgtm
Comment 4 Rui Matos 2017-05-30 10:38:29 UTC 
Review of attachment 352818 [details] [review]:

ok
Comment 5 Florian Müllner 2017-05-30 10:42:29 UTC 
Attachment 352817 [details] pushed as 15d387d - build: Switch to sassc for generating style