GNOME Bugzilla – Bug 783198
Some problems with Windows build, try harder to find right python3 executable
Last modified: 2017-07-07 11:30:04 UTC
glib-mkenums python script is missing --fprod argument and fails to parse multiline comments so it fails on gstpad.h other modules expect python3.exe, but some distribution of python3 use python.exe
Created attachment 352778 [details] [review] Patch for glib-mkenums
Created attachment 352779 [details] [review] Patch for gst-plugins-base meson.build
Created attachment 352780 [details] [review] Patch for gst-plugins-good meson.build
Created attachment 352781 [details] [review] Patch for gst-plugins-ugly meson.build
Created attachment 352782 [details] [review] Patch for gst-plugins-bad (1)
Created attachment 352783 [details] [review] Patch for gst-plugins-bad (2)
Thanks. The python bits should be done differently imho, using the new python3 module: http://mesonbuild.com/Python-3-module.html So something like this probably: python = import('python3').find_python() or somesuch.
Comment on attachment 352782 [details] [review] Patch for gst-plugins-bad (1) Can this should just re-use the python var from the top-level meson.build ?
Comment on attachment 352778 [details] [review] Patch for glib-mkenums Pushed the patch split up into two :) commit 2aa486b5c932a84691ca099d4c4afab7cd1e2b71 Author: Matej Knopp <matej.knopp@gmail.com> Date: Sun May 28 22:29:20 2017 +0200 glib-mkenums: add back missing --fprod option ... in glib-mkenums python port. https://bugzilla.gnome.org/show_bug.cgi?id=779332 https://bugzilla.gnome.org/show_bug.cgi?id=783198 commit 1eaf57bb3b3f36f6912427f58a3e566fd95722ce Author: Matej Knopp <matej.knopp@gmail.com> Date: Sun May 28 22:29:20 2017 +0200 glib-mkenums: Fix parsing of multiline comments ... in glib-mkenums python port. https://bugzilla.gnome.org/show_bug.cgi?id=779332 https://bugzilla.gnome.org/show_bug.cgi?id=783198
Matej, were you planning on updating the patches or should I just fix it ?
Fixed in master, hopefully.