After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783188 - kmssink: add 'xilinx_drm' to the drivers list
kmssink: add 'xilinx_drm' to the drivers list
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-29 08:16 UTC by Guillaume Desmottes
Modified: 2017-06-05 13:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
kmssink: Add xilinx_drm to the list of drivers (937 bytes, patch)
2017-05-29 08:16 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2017-05-29 08:16:14 UTC 
.
Comment 1 Guillaume Desmottes 2017-05-29 08:16:30 UTC 
Created attachment 352753 [details] [review]
kmssink: Add xilinx_drm to the list of drivers

This prevent having to set the driver-name explicitly when running on
Zynq UltraScale+ boards.
Comment 2 Nicolas Dufresne (ndufresne) 2017-05-29 13:24:10 UTC 
Review of attachment 352753 [details] [review]:

Looks good except that it's weird that the naming is non-standard. Is this a name from mainline driver ? If it's not mainline, will that name change in the future ?
Comment 3 Guillaume Desmottes 2017-05-31 07:27:45 UTC 
The driver is public ( https://github.com/Xilinx/linux-xlnx/tree/master/drivers/gpu/drm/xilinx ) but not mainlined yet.
The team is planning to mainline it later this year.

If changing the name is a hard requirement from upstream then I guess it may be changed.
We can wait for the driver to be mainlined before merging this if you prefer. We can use the driver-name property for now.
Comment 4 Nicolas Dufresne (ndufresne) 2017-05-31 13:38:55 UTC 
Well, long term plan is to get rid of this list, so I'm not going to prevent adding a name, so I think in the short term it's not a big deal if an unstable name gets in.
Comment 5 Guillaume Desmottes 2017-06-05 07:34:53 UTC 
Agreed, and it's trivial to change later if needed.
Comment 6 Víctor Manuel Jáquez Leal 2017-06-05 10:55:27 UTC 
Review of attachment 352753 [details] [review]:

let's merge it then
Comment 7 Víctor Manuel Jáquez Leal 2017-06-05 10:58:13 UTC 
Attachment 352753 [details] pushed as d373c44 - kmssink: Add xilinx_drm to the list of drivers