GNOME Bugzilla – Bug 783176
Tweak Tool: Implement Design mockups
Last modified: 2018-01-24 15:22:17 UTC
The hard part will be dealing with Tweak's Tools disguised ListBoxRows for almost everything, but we can at least get closer to the Design mockup. https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/tweak-tool/tweak-tool-wires.png shell.css: Don't override the sidebar bg color
Created attachment 352722 [details] [review] shell.css: Don't override the sidebar bg color This more closely resembles the UI of the gnome-control-center redesign
Created attachment 352723 [details] [review] appearance: Implement mockup from Design Team Mockup says "System" theme, but I left it as "Shell" theme since that seems clearer to me.
Created attachment 352725 [details] [review] desktop: Implement mockup from Design Team Mockup shows "Image File" for Background but "Image" for Lock Screen, so I just used "Image" for both for now.
Created attachment 352726 [details] [review] widgets: Add optional desc property to GSettingsSwitchTweak This allows for a "subtitle" to explain Switches
Created attachment 352727 [details] [review] keymouse: Partially implement mockup from Design Team Mockup says "Input Methods" but gnome-control-center says "Input Sources" so I kept the "Sources" name for now.
Created attachment 352728 [details] [review] keymouse: Change Key theme ComboBox to Emacs Input Switch
Created attachment 352729 [details] [review] keymouse: Change Overview Shortcut ComboBox to ButtonBox
Created attachment 352738 [details] [review] windows: Implement mockup from Design Team
Created attachment 352746 [details] [review] keymouse: Change Overview Shortcut ComboBox to ButtonBox (drop some unnecessary lines from previous version of this patch)
Created attachment 352747 [details] [review] keymouse: Change Overview Shortcut ComboBox to ButtonBox (fixes previous version of this patch by not setting ButtonBox to expand)
Created attachment 352750 [details] [review] keymouse: Change Overview Shortcut ComboBox to ButtonBox (fix warning in previous version of this patch)
Review of attachment 352722 [details] [review]: might as well remove the css class from the code (in tweakview.py)
Review of attachment 352723 [details] [review]: ok
Review of attachment 352725 [details] [review]: unsure about the removal of the computer icon tweak, after all this is the tweak tool and we have the setting...
Review of attachment 352726 [details] [review]: looks fine
Review of attachment 352727 [details] [review]: ++
(In reply to Rui Matos from comment #12) > Review of attachment 352722 [details] [review] [review]: > > might as well remove the css class from the code (in tweakview.py) Maybe leave it in case theme designers still want to theme that?
(In reply to Rui Matos from comment #14) > Review of attachment 352725 [details] [review] [review]: > > unsure about the removal of the computer icon tweak, after all this is the > tweak tool and we have the setting... Sadly, that setting was removed years ago from nautilus https://git.gnome.org/browse/nautilus/commit/?id=331860
Review of attachment 352728 [details] [review]: Not sure about this one... (YOU'RE TAKING OPTIONS AWAY!!!1!)
(In reply to Rui Matos from comment #19) > Review of attachment 352728 [details] [review] [review]: > > Not sure about this one... > > (YOU'RE TAKING OPTIONS AWAY!!!1!) I did look around first. The only gtk-keys.css available in Debian is for Emacs. I guess someone could make a custom file, but it seems a pretty obscure feature right now.
Review of attachment 352738 [details] [review]: looks nice
Review of attachment 352750 [details] [review]: lgtm
Review of attachment 352728 [details] [review]: (In reply to Jeremy Bicha from comment #20) > I did look around first. The only gtk-keys.css available in Debian is for > Emacs. I guess someone could make a custom file, but it seems a pretty > obscure feature right now. Fair enough
(In reply to Jeremy Bicha from comment #18) > Sadly, that setting was removed years ago from nautilus > > https://git.gnome.org/browse/nautilus/commit/?id=331860 Ok, let's push it then (In reply to Jeremy Bicha from comment #17) > > might as well remove the css class from the code (in tweakview.py) > > Maybe leave it in case theme designers still want to theme that? indeed it doesn't hurt. Thanks for the patches!
Attachment 352723 [details] pushed as f16dc6c - appearance: Implement mockup from Design Team Attachment 352725 [details] pushed as 71d001d - desktop: Implement mockup from Design Team Attachment 352726 [details] pushed as d960b51 - widgets: Add optional desc property to GSettingsSwitchTweak Attachment 352727 [details] pushed as de2de84 - keymouse: Partially implement mockup from Design Team Attachment 352728 [details] pushed as cbf4c0b - keymouse: Change Key theme ComboBox to Emacs Input Switch Attachment 352738 [details] pushed as 650494c - windows: Implement mockup from Design Team Attachment 352750 [details] pushed as d0a044c - keymouse: Change Overview Shortcut ComboBox to ButtonBox
Comment on attachment 352722 [details] [review] shell.css: Don't override the sidebar bg color Attachment 352722 [details] pushed as 5c0c27c - shell.css: Don't override the sidebar bg color
Created attachment 352820 [details] [review] split tweak_group_shell.py into separate source files
Created attachment 352821 [details] [review] power: Implement mockup from Design Team The dropped settings were dropped from gnome-settings-daemon in 2012 https://git.gnome.org/browse/gnome-settings-daemon/commit/data/?id=a95d9c https://git.gnome.org/browse/gnome-settings-daemon/commit/data/?id=58cb4e
Created attachment 352822 [details] [review] top_bar: Implement mockup from Design Team
Created attachment 352823 [details] [review] workspaces: Partially implement mockup from Design Team
Review of attachment 352823 [details] [review]: ok
Review of attachment 352822 [details] [review]: ok
Review of attachment 352821 [details] [review]: ::: gtweak/tweaks/tweak_group_power.py @@ +62,3 @@ IgnoreLidSwitchTweak(), + Title(_("Power Button Behavior"), "", uid="title-theme"), + GSettingsComboEnumTweak("", "org.gnome.settings-daemon.plugins.power", "power-button-action", size_group=sg), a title and a "disconnected" combo box looks odd
Review of attachment 352820 [details] [review]: ok, that's fair
Attachment 352820 [details] pushed as 702781f - split tweak_group_shell.py into separate source files Attachment 352822 [details] pushed as 0732236 - top_bar: Implement mockup from Design Team Attachment 352823 [details] pushed as e3249e5 - workspaces: Partially implement mockup from Design Team
Making all in po make[1]: Entering directory '/mnt/wd20ezrx-00dc0b0/JHBuild/3.26/checkout/gnome-tweak-tool/po' make gnome-tweak-tool.pot-update make[2]: Entering directory '/mnt/wd20ezrx-00dc0b0/JHBuild/3.26/checkout/gnome-tweak-tool/po' make[2]: *** No rule to make target '../gtweak/tweaks/tweak_group_shell.py', needed by 'gnome-tweak-tool.pot-update'. Stop. make[2]: Leaving directory '/mnt/wd20ezrx-00dc0b0/JHBuild/3.26/checkout/gnome-tweak-tool/po' Makefile:307: recipe for target 'gnome-tweak-tool.pot' failed make[1]: *** [gnome-tweak-tool.pot] Error 2 make[1]: Leaving directory '/mnt/wd20ezrx-00dc0b0/JHBuild/3.26/checkout/gnome-tweak-tool/po' Makefile:625: recipe for target 'all-recursive' failed
Created attachment 352862 [details] [review] power: Implement mockup from Design Team ok, here's an updated version without the "disconnected" combo box
Created attachment 352863 [details] [review] power: Implement mockup from Design Team
Alberts, thanks. That should be fixed now.
Review of attachment 352863 [details] [review]: ok, thanks
Comment on attachment 352863 [details] [review] power: Implement mockup from Design Team Attachment 352863 [details] pushed as 1fa51a1 - power: Implement mockup from Design Team
Created attachment 353507 [details] [review] keymouse: Move xkb panel to Additional Layout Options dialog https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/tweak-tool/tweak-tool-wires.png
Comment on attachment 353507 [details] [review] keymouse: Move xkb panel to Additional Layout Options dialog Attachment 353507 [details] pushed as 5108621 - keymouse: Move xkb panel to Additional Layout Options dialog
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-tweaks/issues/92.