After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783125 - compositor: handle EXIF orientation for backgrounds
compositor: handle EXIF orientation for backgrounds
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
: 776782 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-05-26 11:37 UTC by slatchurie
Modified: 2017-06-21 18:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
compositor: handle EXIF orientation for backgrounds (1.32 KB, patch)
2017-05-26 11:37 UTC, slatchurie 		committed Details | Review

Description slatchurie 2017-05-26 11:37:07 UTC 
Created attachment 352647 [details] [review]
compositor: handle EXIF orientation for backgrounds

When setting a background, the embedded EXIF orientation of the file is not applied.

It is a newcomers gnome-desktop bug https://bugzilla.gnome.org/show_bug.cgi?id=516177

It is also a gnome-shell bug https://bugzilla.gnome.org/show_bug.cgi?id=776782

But I think it is easier to solve this issue in mutter.
Comment 1 Florian Müllner 2017-05-26 12:28:54 UTC 
Review of attachment 352647 [details] [review]:

LGTM - we'll need a similar fix in gnome-control-center as well ...
Comment 2 Florian Müllner 2017-05-26 12:29:28 UTC 
*** Bug 776782 has been marked as a duplicate of this bug. ***
Comment 3 slatchurie 2017-05-26 22:13:22 UTC 
(In reply to Florian Müllner from comment #1)
> Review of attachment 352647 [details] [review] [review]:
> 
> LGTM - we'll need a similar fix in gnome-control-center as well ...

I have made a patch for gnome-control-center and another one for gnome-desktop.

Should I open a bug report for each project ? Or can I post them here ?
Comment 4 Rui Matos 2017-05-29 10:03:33 UTC 
(In reply to slatchurie from comment #3)
> I have made a patch for gnome-control-center and another one for
> gnome-desktop.
> 
> Should I open a bug report for each project ? Or can I post them here ?

Please open a bug for each module.
Comment 5 slatchurie 2017-06-21 18:09:42 UTC 
Sorry to bother you again,
the patches for the gnome-control-center have already been pushed a few weeks ago, but this one isn't. Yet it is the most important one.

Do I have to do something else ?
Comment 6 Florian Müllner 2017-06-21 18:24:37 UTC 
(In reply to slatchurie from comment #5)
> Do I have to do something else ?

Tell us that you need someone to push the patch for you :-)