GNOME Bugzilla – Bug 783047
Many apps crash in gdk_event_source_prepare when logging out of GNOME
Last modified: 2017-08-16 15:54:04 UTC
See this Fedora bug for the backtraces: https://bugzilla.redhat.com/show_bug.cgi?id=1258818 It looks very similar to this older Fedora bug, except that it one is about gdk_event_source_check and the other gdk_event_source_prepare: https://bugzilla.redhat.com/show_bug.cgi?id=1366897 It was fixed by: https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-22&id=43b2b107f123a97e2040ddb7f429b611a16bdc41 I don't know if this is also triggered by logging out of GNOME, but it looks plausible, so I am running with it.
Created attachment 352502 [details] [review] wayland: Don't abort when preparing the source if connection is lost
Bug 745289 was another related issue fixed by: https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-22&id=53028ff3bb0610f5fb4df360391af9ee23f61cfa
You have indentation issues in the patch (the { }), other than that, I think it makes sense.
(In reply to Olivier Fourdan from comment #3) > You have indentation issues in the patch (the { }), other than that, I think > it makes sense. Ah no, sorry, my bad, indentation is fine!
Review of attachment 352502 [details] [review]: makes sense. please put it on gtk-3-22 and master
Comment on attachment 352502 [details] [review] wayland: Don't abort when preparing the source if connection is lost Thanks for the reviews. Pushed to master and gtk-3-22.
*** Bug 783604 has been marked as a duplicate of this bug. ***