After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783006 - Show values that have a logical False representation.
Show values that have a logical False representation.
Status: RESOLVED FIXED
Product: d-feet
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: D-Feet Maintainer(s)
D-Feet Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-05-23 16:58 UTC by Benjamin Berg
Modified: 2017-08-14 11:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Show values that have a logical False representation. (1.02 KB, patch)
2017-05-23 16:59 UTC, Benjamin Berg 		none Details | Review

Description Benjamin Berg 2017-05-23 16:58:59 UTC 
If e.g. the result is a 0 integer then the value is not shown.
This is confusing and the fix is rather simple.
Comment 1 Benjamin Berg 2017-05-23 16:59:02 UTC 
Created attachment 352437 [details] [review]
Show values that have a logical False representation.

Correctly test whether a value has been retrieved (not None) instead of
testing whether the value is logically True to decide on showing it.
Comment 2 Christian Kellner 2017-08-14 11:02:36 UTC 
Review of attachment 352437 [details] [review]:

For what it's worth, the one-liner looks good to me and fixes a quite annoying bug.
Comment 3 Thomas Bechtold 2017-08-14 11:04:36 UTC 
Looks good to me. feel free to merge.
Comment 4 Benjamin Berg 2017-08-14 11:07:11 UTC 
Thanks for the review. Pushed to master.