After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782981 - [PATCH] meson fixes
[PATCH] meson fixes
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.91.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-05-23 08:43 UTC by Marc-Antoine Perennou
Modified: 2017-08-14 21:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix gdk headers installation path (1.45 KB, patch)
2017-05-23 08:44 UTC, Marc-Antoine Perennou 		committed Details | Review
properly dist config.h meson templates (838 bytes, patch)
2017-05-23 08:45 UTC, Marc-Antoine Perennou 		none Details | Review
properly dist config.h meson templates (839 bytes, patch)
2017-05-24 08:11 UTC, Marc-Antoine Perennou 		rejected Details | Review
meson: install gdkdrawcontext.h (730 bytes, patch)
2017-05-24 08:11 UTC, Marc-Antoine Perennou 		committed Details | Review
meson: install gdkvulkancontext.h (745 bytes, patch)
2017-05-24 08:19 UTC, Marc-Antoine Perennou 		committed Details | Review

Description Marc-Antoine Perennou 2017-05-23 08:43:28 UTC 
Some gdk headers weren't installed in the correct location and the *config.h.meson files are not in the release tarball.
Comment 1 Marc-Antoine Perennou 2017-05-23 08:44:35 UTC 
Created attachment 352392 [details] [review]
fix gdk headers installation path
Comment 2 Marc-Antoine Perennou 2017-05-23 08:45:00 UTC 
Created attachment 352393 [details] [review]
properly dist config.h meson templates
Comment 3 Marc-Antoine Perennou 2017-05-24 08:11:02 UTC 
Created attachment 352474 [details] [review]
properly dist config.h meson templates
Comment 4 Marc-Antoine Perennou 2017-05-24 08:11:30 UTC 
Created attachment 352475 [details] [review]
meson: install gdkdrawcontext.h
Comment 5 Marc-Antoine Perennou 2017-05-24 08:19:22 UTC 
Created attachment 352478 [details] [review]
meson: install gdkvulkancontext.h
Comment 6 Tim-Philipp Müller 2017-05-31 15:26:02 UTC 
We could probably also just get rid of the config.h.meson template.

I was going to write that the only interesting bits in there are probably these:

/* Enable extensions on AIX 3, Interix.  */
#ifndef _ALL_SOURCE
# undef _ALL_SOURCE
#endif
/* Enable GNU extensions on systems that have them.  */
#ifndef _GNU_SOURCE
# undef _GNU_SOURCE
#endif
/* Enable threading extensions on Solaris.  */
#ifndef _POSIX_PTHREAD_SEMANTICS
# undef _POSIX_PTHREAD_SEMANTICS
#endif
/* Enable extensions on HP NonStop.  */
#ifndef _TANDEM_SOURCE
# undef _TANDEM_SOURCE
#endif
/* Enable general extensions on Solaris.  */
#ifndef __EXTENSIONS__
# undef __EXTENSIONS__
#endif

But then I noticed that they're all #ifndef #undef so basically no-ops ;)
Comment 7 Emmanuele Bassi (:ebassi) 2017-08-14 21:27:25 UTC 
Review of attachment 352392 [details] [review]:

Looks good.
Comment 8 Emmanuele Bassi (:ebassi) 2017-08-14 21:27:36 UTC 
Review of attachment 352478 [details] [review]:

Looks good.
Comment 9 Emmanuele Bassi (:ebassi) 2017-08-14 21:27:43 UTC 
Review of attachment 352475 [details] [review]:

Looks good.
Comment 10 Emmanuele Bassi (:ebassi) 2017-08-14 21:27:47 UTC 
Review of attachment 352474 [details] [review]:

We dropped Autotools from the build, so I guess this is obsolete.
Comment 11 Emmanuele Bassi (:ebassi) 2017-08-14 21:33:49 UTC 
Attachment 352392 [details] pushed as 807c744 - fix gdk headers installation path
Attachment 352475 [details] pushed as c9caa61 - meson: install gdkdrawcontext.h
Attachment 352478 [details] pushed as 49d0b4c - meson: install gdkvulkancontext.h