After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782959 - glimagesink does not seem to honor gst_video_overlay_set_render_rectangle
glimagesink does not seem to honor gst_video_overlay_set_render_rectangle
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.8.3
Other Linux
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-22 16:06 UTC by Séverin Lemaignan
Modified: 2017-07-16 02:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gl/window/x11: implement set_render_rectangle (6.12 KB, patch)
2017-07-14 15:31 UTC, Matthew Waters (ystreet00) 		committed Details | Review

Description Séverin Lemaignan 2017-05-22 16:06:23 UTC 
In pdfpc (a PDF presentation tool that support displaying videos linked into a PDF as overlays), we switched from xvimagesink to glimagesink due to client-side decoration issues with xvimagesink (detail here: https://github.com/pdfpc/pdfpc/issues/197#issuecomment-297718608 ).

It appears however that glimagesink does not honor the `set_render_rectangle` ( https://github.com/pdfpc/pdfpc/blob/master/src/classes/action/movie.vala#L318 ): when xvimagesink is used, the video is properly framed and positioned on top of the PDF page. However, when replacing xvimagesink by glimagesink, the video is displayed using the entirety of the parent window, seemingly ignoring set_render_rectangle.
Comment 1 Matthew Waters (ystreet00) 2017-07-14 15:31:07 UTC 
Created attachment 355611 [details] [review]
gl/window/x11: implement set_render_rectangle

Completely untested.  Does this help? :)
Comment 2 Matthew Waters (ystreet00) 2017-07-16 02:51:35 UTC 
It's a step in the right direction

commit 1656d8000d2c1988b1170bc671d48f42b0f91f4c
Author: Matthew Waters <matthew@centricular.com>
Date:   Sat Jul 15 01:24:52 2017 +1000

    gl/window/x11: implement set_render_rectangle support
    
    https://bugzilla.gnome.org/show_bug.cgi?id=782959