After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782922 - build: Make gudev and libdrm checks reusable across plugins
build: Make gudev and libdrm checks reusable across plugins
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 782923
 
 
Reported: 2017-05-21 14:29 UTC by Carlos Rafael Giani
Modified: 2018-01-27 11:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libdrm checks patch (3.15 KB, patch)
2017-05-21 14:31 UTC, Carlos Rafael Giani 		none Details | Review
gudev checks patch (1.37 KB, patch)
2017-05-21 14:31 UTC, Carlos Rafael Giani 		accepted-commit_now Details | Review
libdrm checks patch v2 (3.86 KB, patch)
2017-06-07 15:51 UTC, Carlos Rafael Giani 		none Details | Review

Description Carlos Rafael Giani 2017-05-21 14:29:34 UTC 
Currently, gudev is checked inside the uvch264 block, and libdrm is checked inside the KMS block. These two features will be needed in future commits, so factor them out as their own standalone checks.
Comment 1 Carlos Rafael Giani 2017-05-21 14:31:25 UTC 
Created attachment 352293 [details] [review]
libdrm checks patch
Comment 2 Carlos Rafael Giani 2017-05-21 14:31:54 UTC 
Created attachment 352294 [details] [review]
gudev checks patch
Comment 3 Matthew Waters (ystreet00) 2017-05-21 15:14:36 UTC 
Review of attachment 352293 [details] [review]:

This fails to build here.

::: configure.ac
@@ +2255,3 @@
 AG_GST_CHECK_FEATURE(WAYLAND, [wayland sink], wayland , [
+  if test "x$HAVE_DRM" = "xyes"; then
+    PKG_CHECK_MODULES(WAYLAND, wayland-client >= 1.4.0 wayland-protocols >= 1.4, [

This removes the drm cflags/libs from WAYLAND_CFLAGS/LIBS which breaks building the wayland plugin.  Either DRM_CFLAGS/LIBS needs to be readded to WAYLAND_CFLAGS/LIBS or DRM_CFLAGS/LIBS needs to be added to the flags gst/wayland/Makefile.am like done for kms in this patch
Comment 4 Matthew Waters (ystreet00) 2017-05-22 09:50:07 UTC 
Review of attachment 352294 [details] [review]:

ack.
Comment 5 Sebastian Dröge (slomo) 2017-06-07 07:22:05 UTC 
Ping? Carlos?
Comment 6 Carlos Rafael Giani 2017-06-07 15:09:30 UTC 
Unfortunately I am not able to follow up this week. Will do that early next week.
Comment 7 Carlos Rafael Giani 2017-06-07 15:51:14 UTC 
Created attachment 353344 [details] [review]
libdrm checks patch v2

Ah nevermind, I got a chance to upload my stuff :)

Here is the updated version that also adds the DRM flags to the wayland plugin.
Comment 8 Tim-Philipp Müller 2018-01-27 11:10:38 UTC 
Since this is being done for bug #782923 and gst-gl has moved to -base now, and there hasn't been any follow-up here, let's close this.

Please attach these patches to the other bug if you ever have time to follow up, thanks! (And they'll have to be reworked against -base I presume)