GNOME Bugzilla – Bug 782920
flvmux port to Aggregator
Last modified: 2018-02-26 11:25:08 UTC
Here is a port of flvmux to GstAggregator. The big feature is that it doesn't block if there is a gap in the input stream.
Created attachment 352286 [details] [review] audioaggregator: Don't hold object locks across calls to aggregate_one https://bugzilla.gnome.org/show_bug.cgi?id=782878
Created attachment 352287 [details] [review] aggregator: Don't restrict sink pad names Sink pads could have other names than sink_%u
Created attachment 352288 [details] [review] aggregator: Request pad templates which are not request pad
Created attachment 352289 [details] [review] flv2: flvmux ported to the GstAggregator This makes it possible to create a flv file from a live source and not stop when there are packet drops.
I should mention that this is largely the work of Vincent Penquerc'h And here is a less squashed version: https://git.collabora.com/cgit/user/tester/gst-plugins-bad.git/log/?h=flvmux-agg-not-squashed
We should port the existing one in -good over once aggregator moves to core (this cycle hopefully?).
Alternatively, do what I did in the oggmux port (link in the move-aggregator bug) and add a private copy of aggregator to flxmux with a different GType namespace, until it gets moved.
Review of attachment 352288 [details] [review]: Feel free to push after the log change. ::: gst-libs/gst/base/gstaggregator.c @@ +1622,3 @@ +not_request: + { + GST_WARNING_OBJECT (self, "request new pad that is not a REQUEST pad\n"); s/request/requested/
Comment on attachment 352289 [details] [review] flv2: flvmux ported to the GstAggregator Let's port the existing one instead of adding a temporary flv2
This is a port of the code from -good, we just gave it a new name because GstAggregator is in -bad and we wanted to make it easier to test them side by side.
Pushing the auxiliary patches Attachment 352287 [details] pushed as 8f0fba5 - aggregator: Don't restrict sink pad names Attachment 352288 [details] pushed as fbfc427 - aggregator: Request pad templates which are not request pad
This can probably go in now, in place of the original flvmux in -good.
Merged into -good: commit 8b814f6351913689de3cce336e862436ea3df6ca (HEAD -> master, upstream/master) Author: Vincent Penquerc'h <vincent.penquerch@collabora.com> Date: Wed Dec 20 15:23:26 2017 -0500 flv: flvmux ported to the GstAggregator This makes it possible to create a flv file from a live source and not stop when there are packet drops. https://bugzilla.gnome.org/show_bug.cgi?id=782920
This is likely related to blocker bug #793457. We may have to revert if no one has time to come up with a fix fwiw.