After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782878 - audioaggregator: Drop object locks while calling aggregate_one_buffer vfunc
audioaggregator: Drop object locks while calling aggregate_one_buffer vfunc
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-20 17:10 UTC by Olivier Crête
Modified: 2017-05-21 16:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
audioaggregator: Don't hold object locks across calls to aggregate_one (3.71 KB, patch)
2017-05-20 17:10 UTC, Olivier Crête 		committed Details | Review

Description Olivier Crête 2017-05-20 17:10:33 UTC 
Right now, the audioaggregator calls hold the object locks for both pad and element object locks while calling the ->aggregate_one_buffer() vfunc. The attached patch just drops the locks while calling it. There is a little performance penalty, but I think it's worth it for correctness. Please yell if you disagree or I'll merge it soonish.
Comment 1 Olivier Crête 2017-05-20 17:10:50 UTC 
Created attachment 352236 [details] [review]
audioaggregator: Don't hold object locks across calls to aggregate_one
Comment 2 Olivier Crête 2017-05-21 16:45:58 UTC 
Got reviewed on the flv2mux bug, merging!