After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782693 - dashdemux: Initialize sidx_position to GST_CLOCK_TIME_NONE
dashdemux: Initialize sidx_position to GST_CLOCK_TIME_NONE
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.12.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-16 14:29 UTC by Seungha Yang
Modified: 2017-06-12 14:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
dashdemux: Initialize sidx_position to GST_CLOCK_TIME_NONE (1.15 KB, patch)
2017-05-16 14:30 UTC, Seungha Yang
committed Details | Review

Description Seungha Yang 2017-05-16 14:29:46 UTC
If a manifest has non-zero presentation time offset
(i.e., earliest presentation time specified by sidx box is not zero),
the initial sidx position shouldn't be zero. Since we cannot define
exact sidx position until parsing sidx box, set the value to unknown.
Comment 1 Seungha Yang 2017-05-16 14:30:26 UTC
Created attachment 351974 [details] [review]
dashdemux: Initialize sidx_position to GST_CLOCK_TIME_NONE
Comment 2 Seungha Yang 2017-05-16 14:36:47 UTC
Since sidx_position is automatically initialized to zero in current code, demux try to initial sidx seek at
https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/ext/dash/gstdashdemux.c#n2286

The problem is, the sidx seeking is failed for non-zero presentation time offset stream. I've never seen public stream which can reproduce this issue, but I happen in my private stream.
Comment 3 Sebastian Dröge (slomo) 2017-05-16 14:44:58 UTC
Attachment 351974 [details] pushed as 1c6cd54 - dashdemux: Initialize sidx_position to GST_CLOCK_TIME_NONE