After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782608 - Fixes for RTL languages
Fixes for RTL languages
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2017-05-13 20:08 UTC by Marcus Lundblad
Modified: 2017-10-08 19:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
storedRoute: Print route summary according to locale direction (2.31 KB, patch)
2017-05-15 21:07 UTC, Marcus Lundblad
none Details | Review
storedRoute: Print route summary according to locale direction (2.30 KB, patch)
2017-10-08 19:32 UTC, Marcus Lundblad
committed Details | Review

Description Marcus Lundblad 2017-05-13 20:08:58 UTC
Since I have been working with localization of a web UI at work, and we have Arabic-speaking customers, I thought I should do some RTL testing of Maps.
One thing I found is that the rendering of stored route searches in the search popover is always rendered "Place 1 → Place 2 →", I think we should maybe reverse the arrow in these cases, but it might be a bit more complicated, as if the leading text in the string is using a LTR charset (let's say the search used a latin name, despite the locale being an RTL one) the overall string direction will be LTR (as far as I know). There might be more things, but lo-and-behold the sliding animations and the back arrow and so forth for transit routing actually seems to work as expected! :-)
Comment 1 Marcus Lundblad 2017-05-14 19:58:03 UTC
Maybe the places in the stored route presentation should always be ordered according to the locales direction (by using Unicode direction override characters) and the arrows would always be pointing in the "direction of the language".
Comment 2 Marcus Lundblad 2017-05-14 19:59:11 UTC
Another thing we might want to mirror is the location of the arribution logo and text (the scale is already mirrored, I think libchamplain does that).
Comment 3 Marcus Lundblad 2017-05-15 21:07:12 UTC
Created attachment 351922 [details] [review]
storedRoute: Print route summary according to locale direction

Reverse the direction of separating arrows of stored route search results.
Also add Unicode directional characters according to the locale direction
to get the right rendering order for place names using the "opposite"
direction from the currently running locale.
Comment 4 Marcus Lundblad 2017-10-08 19:32:51 UTC
Created attachment 361150 [details] [review]
storedRoute: Print route summary according to locale direction

Reverse the direction of separating arrows of stored route search results.
Also add Unicode directional characters according to the locale direction
to get the right rendering order for place names using the "opposite"
direction from the currently running locale.
Comment 5 Marcus Lundblad 2017-10-08 19:35:46 UTC
Attachment 361150 [details] pushed as 32cc59d - storedRoute: Print route summary according to locale direction