After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782552 - glmemory: remove use of glDrawBuffer in tex_copy
glmemory: remove use of glDrawBuffer in tex_copy
Status: RESOLVED DUPLICATE of bug 782376
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-12 10:04 UTC by Haihua Hu
Modified: 2017-05-12 10:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
glmemory: remove use of glDrawBuffer in tex_copy (1.04 KB, patch)
2017-05-12 10:05 UTC, Haihua Hu
none Details | Review

Description Haihua Hu 2017-05-12 10:04:16 UTC
glDrawBuffer is not compatible with GLES 3.0 and also the usage is not necessary here.
Comment 1 Haihua Hu 2017-05-12 10:05:01 UTC
Created attachment 351707 [details] [review]
glmemory: remove use of glDrawBuffer in tex_copy
Comment 2 Sebastian Dröge (slomo) 2017-05-12 10:09:49 UTC
Why is it not necessary? This is solved in bug #782376 already though, but if it's unnecessary we should remove the call completely.
Comment 3 Haihua Hu 2017-05-12 10:36:32 UTC
(In reply to Sebastian Dröge (slomo) from comment #2)
> Why is it not necessary? This is solved in bug #782376 already though, but
> if it's unnecessary we should remove the call completely.

Your solution is better, because we should make sure the gl state is right when call biltframebuffer which the draw buffer must be GL_COLOR_ATTACHMENT0.
Comment 4 Sebastian Dröge (slomo) 2017-05-12 10:49:49 UTC

*** This bug has been marked as a duplicate of bug 782376 ***